dd-firmware / firmware / App / Controllers

SpentChamberFill.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 4
Last Commit: 01 Aug
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Jul
7:17 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
Thursday 30 Jul
7:14 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

updated now

updated now

6:52 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

code review commits

Options
    • -1
    • +1
    ./SpentChamberFill.c
  2. … 1 more file in changeset.
Wednesday 29 Jul
2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
Tuesday 28 Jul
9:51 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Resolving code review comments

Options
    • -2
    • +3
    ./SpentChamberFill.c
  2. … 1 more file in changeset.
Monday 27 Jul
10:06 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

3:58 pm

Sean Nash

keep a blank line between declaration(s) and code.

keep a blank line between declaration(s) and code.

3:57 pm

Sean Nash

If level can be overridden, you should use get function.

If level can be overridden, you should use get function.

3:55 pm

Sean Nash

Add blank line before banner.

Add blank line before banner.

Friday 24 Jul
10:11 am

Vinayakam Mani

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

10:07 am

Vinayakam Mani

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

9:32 am

Vinayakam Mani

Remove extra paranthesis.

Remove extra paranthesis.

9:29 am

Vinayakam Mani

Remove empty lines

Remove empty lines

9:28 am

Vinayakam Mani

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

9:24 am

Vinayakam Mani

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

Thursday 23 Jul
10:12 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Fix 2

Options
    • -5
    • +5
    ./SpentChamberFill.c
  2. … 1 more file in changeset.
Monday 20 Jul
4:39 pm

Vinayakam Mani

Delete it.

Delete it.

4:32 pm

Vinayakam Mani

Remove blank spaces after =.

Remove blank spaces after =.

4:31 pm

Vinayakam Mani

To be deleted this line?

To be deleted this line?

4:25 pm

Vinayakam Mani

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as w...

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as well.

4:19 pm

Vinayakam Mani

I guess we can remove the "balancingChamberFillInProgress" check here.

I guess we can remove the "balancingChamberFillInProgress" check here.

10:33 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
Sunday 19 Jul
9:20 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

code re-organisation

Options
    • -152
    • +32
    ./SpentChamberFill.c
  2. … 5 more files in changeset.
Friday 17 Jul
1:57 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Initial Changes

Options
    • -17
    • +168
    ./SpentChamberFill.c
  2. … 5 more files in changeset.