leahi-fwcommon

WatchdogMgmt.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 17 Jul
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 mins ago

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

6 mins ago

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

33 mins ago

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

40 mins ago

Dara Navaei

Any fault alarm here?

Any fault alarm here?

54 mins ago

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

2 hrs ago

Sean Nash

So then no need to initialize it here too. Remove " = FALSE".

So then no need to initialize it here too. Remove " = FALSE".

Wednesday 22 Jul
9:28 pm

Vendor - TEL - Suresh Dharnala

I agree but it is already in the init function.

I agree but it is already in the init function.

1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

Tuesday 21 Jul
4:55 pm

Sean Nash

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

4:32 pm

Sean Nash

You can do this sendMessage just once after else.

You can do this sendMessage just once after else.

10:35 am

Vendor - TEL - Arpita Srivastava

add a space before and after 0

add a space before and after 0

10:35 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

10:33 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

10:27 am

Vendor - TEL - Arpita Srivastava

minor spell issue : change responceStatus to responseStatus

minor spell issue : change responceStatus to responseStatus

10:26 am

Vendor - TEL - Arpita Srivastava

add offRequestAwaitingUserConfirmation and offRequestPendingTimer to outputs

add offRequestAwaitingUserConfirmation and offRequestPendingTimer to outputs

10:24 am

Vendor - TEL - Arpita Srivastava

should we move the initialization in the init function?

should we move the initialization in the init function?

10:19 am

Vendor - TEL - Arpita Srivastava

please break this line into two lines

please break this line into two lines

10:19 am

Vendor - TEL - Arpita Srivastava

Vendor - TEL - Arpita Srivastava please add a space before and after in sizeof(U32) in [sizeof(U32)]

Vendor - TEL - Arpita Srivastava
please add a space before and after in sizeof(U32) in [sizeof(U32)]

10:16 am

Vendor - TEL - Arpita Srivastava

please add a space before and after 0 in payload[0]

please add a space before and after 0 in payload[0]

10:15 am

Vendor - TEL - Arpita Srivastava

output is none

output is none

10:13 am

Vendor - TEL - Arpita Srivastava

please break the line in two or more.

please break the line in two or more.

10:12 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'

10:12 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'

10:12 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'

10:12 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'

10:11 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'

10:11 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'