firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
added

added

LDT-5155 cr comments addressed

Add blank line after declarations.

Add blank line after declarations.

changes made to run the rinse pump without the config active

LEAHI-DD-FIRMWARE-LDT-5155_(DD) D79 rinse pump does not run when commanded (staging 94+)
LEAHI-DD-FIRMWARE-LDT-5155_(DD) D79 rinse pump does not run when commanded (staging 94+)
Please add another sub condition for now that sub mode is in DD_POST_GEN_DIALYSATE_STATE_COMPLETE. Make sure you transition substate from Post gen start state to complete state for now to wait for ...

Please add another sub condition for now that sub mode is in DD_POST_GEN_DIALYSATE_STATE_COMPLETE. Make sure you transition substate from Post gen start state to complete state for now to wait for this request.

for now, keep this only related for disinfection cmds. for Post gen and standby. Follow the similiar messaging like pre-gen and gen dialysate requests and the reply back. ( but one message/handler )

for now, keep this only related for disinfection cmds.

for Post gen and standby. Follow the similiar messaging like pre-gen and gen dialysate requests and the reply back. ( but one message/handler )

are we rejecting this request for Aug Month demo, I guess, you still need to accept these requests and set the corresponding pending DD disinfect request flags.

are we rejecting this request for Aug Month demo, I guess, you still need to accept these requests and set the corresponding pending DD disinfect request flags.

Do we have a MSG_ID for the selection of disinfection? If not, lets rename and repurpose this one.

Do we have a MSG_ID for the selection of disinfection? If not, lets rename and repurpose this one.

MSG_ID_TD_DD_POSTGEN_STANDBY_REQUEST: to perform post gen and standby mode request transition.

MSG_ID_TD_DD_POSTGEN_STANDBY_REQUEST: to perform post gen and standby mode request transition.

LEAHI-DD-FIRMWARE-LDT-5470_Post Treatment - FW Implementation - 4/3:
LEAHI-DD-FIRMWARE-LDT-5470_Post Treatment - FW Implementation - 4/3:
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Add TODO to restore later. Why did this need to be commented out?

Add TODO to restore later. Why did this need to be commented out?

Remove blank line.

Remove blank line.

Restore before merging.

Restore before merging.

LDT-4049: Update FP Standby featured logic

    • -12
    • +8
    ./App/Modes/FPModes/FPModeStandby.c
flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

close D80, D64, D14?

close D80, D64, D14?

D80 : open, D65: Close?

D80 : open, D65: Close?