leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 13
Total Committers: 17
Last Commit: 09:57
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
12 hrs ago

Vendor - TEL - Arpita Srivastava

Merge branch 'LDT-3735-non-volatile-memory' of bitbucket.org:diality-cloud/leahi-common into LDT-5157-conductivity-sensor-calibration

Options
    • -0
    • +140
    /AlarmDefs.h
12 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
Tuesday 14 Jul
11:17 pm

Sean Nash

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

11:10 pm

Sean Nash

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

5:53 pm

Sean Nash

171

171

5:46 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Addressed review comments

Options
    • -76
    • +76
    /AlarmDefs.h
5:04 pm

Sean Nash

Is this too early to tell DD to start? Ask Vinay.

Is this too early to tell DD to start? Ask Vinay.

5:01 pm

Sean Nash

Initialize post treatment too.

Initialize post treatment too.

5:01 pm

Sean Nash

Delete this. No treatment params mode in Leahi.

Delete this. No treatment params mode in Leahi.

5:00 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

4:58 pm

Sean Nash

I would keep this stuff commented out until disinfection is implemented.

I would keep this stuff commented out until disinfection is implemented.

4:55 pm

Sean Nash

Door already not required. Remove.

Door already not required. Remove.

4:54 pm

Sean Nash

break into 2 lines.

break into 2 lines.

4:52 pm

Sean Nash

Let's comment remaining states for now.

Let's comment remaining states for now.

4:52 pm

Sean Nash

Remove this line. There is no syringe detection.

Remove this line. There is no syringe detection.

4:51 pm

Sean Nash

Door is probably not required to be closed in standby. Change to FALSE.

Door is probably not required to be closed in standby. Change to FALSE.

4:51 pm

Sean Nash

Let's remove this for now.

Let's remove this for now.

4:43 pm

Sean Nash

Service record not yet available. Comment out with TODO

Service record not yet available. Comment out with TODO

4:36 pm

Sean Nash

INVALID_REQUEST_FORMAT

INVALID_REQUEST_FORMAT

4:33 pm

Sean Nash

I think we can do this check now, right?

I think we can do this check now, right?

4:31 pm

Sean Nash

Change reject reason to DD_BUSY.

Change reject reason to DD_BUSY.

4:31 pm

Sean Nash

Change reason to FP_BUSY

Change reason to FP_BUSY

4:30 pm

Sean Nash

Fix reject reason name (not filter temperature?)

Fix reject reason name (not filter temperature?)

4:29 pm

Sean Nash

Add a TODO

Add a TODO

4:16 pm

Sean Nash

Use structure instead of U32.

Use structure instead of U32.

4:15 pm

Sean Nash

Make a structure for initiate treatment request payload (with 1 U32 in it) and use structure instead of U32.

Make a structure for initiate treatment request payload (with 1 U32 in it) and use structure instead of U32.

2:43 pm

Sean Nash

Remove blank line.

Remove blank line.

2:42 pm

Sean Nash

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

2:37 pm

Sean Nash

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

2:32 pm

Sean Nash

Add blank line between declarations and rest of function code (throughout this unit)

Add blank line between declarations and rest of function code (throughout this unit)