Activity leahi-fwcommon/PIDControllers.c

3:03 pm

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-4611-4
started review

LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:

9:02 am

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-4003-1
started review

LEAHI-TD-FIRMWARE-LDT-4003_HDF - FW Implementation - 4/4:

4:55 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3975-1
commented on review

Why isn't this TRUE == ?

1:47 pm

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-3975-1
started review

LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:

8:15 am

Sean Nash and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3218-4
finished reviewing

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

3:37 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3218-4
commented on review

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

9:52 am