leahi-common

DDDefs.h

Clone Tools

Stats

Commits this week: 5
Total Committers: 15
Last Commit: 21 Jul
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
44 mins ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

57 mins ago

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1 hr ago

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1 hr ago

Sean Nash

Why commented out?

Why commented out?

2 hrs ago

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

2 hrs ago

Sean Nash

Why?

Why?

2 hrs ago

Sean Nash

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

2 hrs ago

Sean Nash

Use ternary operator to explicitly set to TRUE or FALSE.

Use ternary operator to explicitly set to TRUE or FALSE.

4 hrs ago

Sean Nash

Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

4 hrs ago

Sean Nash

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

4 hrs ago

Sean Nash

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

4 hrs ago

Sean Nash

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

4 hrs ago

Sean Nash

Should return a BOOL (that is what ModeStandby is expecting).

Should return a BOOL (that is what ModeStandby is expecting).

4 hrs ago

Sean Nash

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

4 hrs ago

Sean Nash

Align comment.

Align comment.

4 hrs ago

Sean Nash

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Tuesday 21 Jul
5:45 pm

Sean Nash

I think ( setTxDur - preStop ) should be changed to ( preStop ). Also, I think preStop should be renamed to hepDurMin.

I think ( setTxDur - preStop ) should be changed to ( preStop ).
Also, I think preStop should be renamed to hepDurMin.

4:10 pm

Vinayakam Mani

0.0F(float type).

0.0F(float type).

4:07 pm

Vinayakam Mani

I meant 'handleBicarbChamberCartridgeFillWaterEndState function stops the inlet water to cartridge'.

I meant 'handleBicarbChamberCartridgeFillWaterEndState function stops the inlet water to cartridge'.

2:13 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added? Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

Should this be the "Load Syringe" alarm that you just added?
Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

2:10 pm

Sean Nash

Can we remote this TODO comment?

Can we remote this TODO comment?

2:09 pm

Sean Nash

Remove blank line.

Remove blank line.

2:08 pm

Sean Nash

We should go to dry self test state. Why did this change to Rx state?

We should go to dry self test state. Why did this change to Rx state?

2:07 pm

Sean Nash

Comment - should be "install" not "instll".

Comment - should be "install" not "instll".

9:08 am

Sean Nash

Do we need this?

Do we need this?

9:07 am

Sean Nash

Change this to work for any state (passed as parameter).

Change this to work for any state (passed as parameter).

Monday 20 Jul
4:39 pm

Vinayakam Mani

Delete it.

Delete it.

4:33 pm

Sean Nash

Remove

Remove

4:32 pm

Sean Nash

Alphabetize these includes.

Alphabetize these includes.

4:32 pm

Vinayakam Mani

Remove blank spaces after =.

Remove blank spaces after =.