dd-firmware / firmware / App / Services

NVMessagingDD.c

Clone Tools

Stats

Commits this week: 5
Total Committers: 2
Last Commit: 14:07
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5357_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 9/1:
LEAHI-DD-FIRMWARE-LDT-5357_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 9/1:
Tuesday 04 Aug
3:04 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Added index logic for get calibration request

Options
    • -319
    • +433
    ./NVMessagingDD.c
Monday 03 Aug
5:13 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Update set cal write function of the conductivity sensor

Options
    • -23
    • +44
    ./NVMessagingDD.c
  2. … 1 more file in changeset.
3:52 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Added FPGA implementation for set cal of conductivity sensor

Options
    • -0
    • +3
    ./NVMessagingDD.c
  2. … 6 more files in changeset.
11:05 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
Thursday 30 Jul
11:23 am

Vendor - TEL - Arpita Srivastava

10:23 am

Sean Nash

Wednesday 29 Jul
5:37 pm

Dara Navaei

Tuesday 28 Jul
4:53 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Added Conductivity Sensor Changes

Options
    • -35
    • +42
    ./NVMessagingDD.c
  2. … 5 more files in changeset.
Monday 27 Jul
11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Friday 24 Jul
5:05 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Resolved all build errors

Options
    • -151
    • +134
    ./NVMessagingDD.c
  2. … 4 more files in changeset.
12:31 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Updated set handlers

Options
    • -819
    • +607
    ./NVMessagingDD.c
  2. … 2 more files in changeset.
Thursday 23 Jul
5:22 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Added Conductivity Sensor Record

Options
    • -586
    • +1568
    ./NVMessagingDD.c
  2. … 5 more files in changeset.
11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

10:39 am

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

10:31 am

Dara Navaei

Any fault alarm here?

Any fault alarm here?

10:18 am

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

Wednesday 22 Jul
1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

Wednesday 15 Jul
9:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
9:33 am

Vendor - TEL - Arpita Srivastava

LDT-3735: Addressed review comments

Options
    • -83
    • +116
    ./NVMessagingDD.c
  2. … 4 more files in changeset.