td-firmware / firmware / App / Modes

ModePostTreat.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 3
Last Commit: 10 Aug
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 14 Aug
12:31 pm

Sean Nash

Not needed? Add another BOOL for disinfection option received.

Not needed? Add another BOOL for disinfection option received.

12:23 pm

Sean Nash

Initialize this.

Initialize this.

12:15 pm

Sean Nash

Remove TODO

Remove TODO

12:14 pm

Sean Nash

Remove disable of ejector motor.

Remove disable of ejector motor.

12:09 pm

Sean Nash

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

12:07 pm

Sean Nash

Just move msg handlers from Messaging to here so you don't need a signal.

Just move msg handlers from Messaging to here so you don't need a signal.

12:06 pm

Sean Nash

Move to .c file to make private.

Move to .c file to make private.

12:05 pm

Sean Nash

Not needed.

Not needed.

11:18 am

Sean Nash

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.

11:16 am

Sean Nash

Missing heat citric

Missing heat citric

11:09 am

Sean Nash

Put back to reserved

Put back to reserved

Wednesday 05 Aug
10:49 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4050_Post Treatment - FW Implementation - 1/3:
LEAHI-TD-FIRMWARE-LDT-4050_Post Treatment - FW Implementation - 1/3:
Friday 22 May
3:39 pm

Vendor - TEL - Praneeth Bunne

1:31 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

11:47 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./ModePostTreat.c
  2. … 14 more files in changeset.
Wednesday 20 May
3:49 pm

Vendor - TEL - Arpita Srivastava

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

Tuesday 19 May
3:37 pm

Vendor - TEL - Arpita Srivastava

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

This merge conflict is still unresolved.

This merge conflict is still unresolved.

3:35 pm

Vendor - TEL - Arpita Srivastava

leak in the comment section.

leak in the comment section.

3:34 pm

Sean Nash

Where is alarm 191..203?

Where is alarm 191..203?

Monday 18 May
9:45 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

9:44 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Friday 15 May
11:02 am

Vendor - TEL - Praneeth Bunne

LDT-1886: Remove backOffAfterRetract variable and update brief

Options
    • -1
    • +2
    ./ModePostTreat.c
  2. … 1 more file in changeset.
Tuesday 12 May
1:58 pm

Vendor - TEL - Arpita Srivastava

We only add File level or global variables in Inputs and Outputs. Please remove functions from the input section of this and other functions.

We only add File level or global variables in Inputs and Outputs.
Please remove functions from the input section of this and other functions.

Friday 08 May
11:17 am

Vendor - TEL - Varshini Nagabooshanam

11:16 am

Vendor - TEL - Praneeth Bunne

LDT-1886: Added BP rotate edge condition and made door close not required before ejector extend

Options
    • -0
    • +2
    ./ModePostTreat.c
  2. … 2 more files in changeset.
Wednesday 06 May
11:43 am

Sean Nash

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

Tuesday 05 May
4:37 pm

Vendor - TEL - Praneeth Bunne

LDT-1886: Addressed code review comments

Options
    • -21
    • +21
    ./ModePostTreat.c
  2. … 7 more files in changeset.
12:10 pm

Vendor - TEL - Varshini Nagabooshanam

Add a detail for Message Sent for the broadcast data message.

Add a detail for Message Sent for the broadcast data message.

12:09 pm

Vendor - TEL - Varshini Nagabooshanam

create local Bool

create local Bool