td-firmware / firmware / App / Modes

ModePreTreat.h

Clone Tools

Stats

Commits this week: 8
Total Committers: 6
Last Commit: 10 Aug
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 13 Aug
1:00 pm

Vendor - TEL - Vijay Pamula

11:15 am

Sean Nash and Vendor - TEL - Arpita Srivastava

9:53 am

Vendor - TEL - Arpita Srivastava

Add to inputs : heparinSetupResumeRequested

Add to inputs : heparinSetupResumeRequested

9:51 am

Vendor - TEL - Arpita Srivastava

Add @alarm

Add @alarm

9:47 am

Vendor - TEL - Arpita Srivastava

Add to inputs : interruptedPreTxHeparinSetupState

Add to inputs : interruptedPreTxHeparinSetupState

Wednesday 12 Aug
10:26 am

Sean Nash

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

10:25 am

Sean Nash

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

10:21 am

Sean Nash

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

10:11 am

Sean Nash

Is this still necessary? Comment out before merging to staging.

Is this still necessary? Comment out before merging to staging.

10:10 am

Sean Nash

Why are registers being repeated? Sync w/ latest HDD.

Why are registers being repeated? Sync w/ latest HDD.

10:08 am

Sean Nash

Can we remove this commented out line of code?

Can we remove this commented out line of code?

10:07 am

Sean Nash

Why is this commented out?

Why is this commented out?

10:05 am

Sean Nash

Why is state transition and publish removed?

Why is state transition and publish removed?

Wednesday 05 Aug
3:28 pm

Vendor - TEL - Vijay Pamula

2:37 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModePreTreat.h
  2. … 6 more files in changeset.
12:56 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

12:45 pm

Sean Nash

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

Friday 31 Jul
11:10 am

Vendor - TEL - Arpita Srivastava

While you are updating this file, can please break this line?

While you are updating this file, can please break this line?

11:08 am

Vendor - TEL - Arpita Srivastava

Can we align like this result = u32BroadcastIntervalOverride( message, &preTreatmentStatePublishInterval, TASK_GENERAL_INTERVAL );

Can we align like this
result = u32BroadcastIntervalOverride( message,
&preTreatmentStatePublishInterval,
TASK_GENERAL_INTERVAL );

11:07 am

Vendor - TEL - Arpita Srivastava

Add to inputs: preTreatmentStatePublishInterval

Add to inputs: preTreatmentStatePublishInterval

Thursday 30 Jul
2:50 pm

Vendor - TEL - Vijay Pamula

Updated to store the result in a local BOOL

Updated to store the result in a local BOOL

2:32 pm

Sean Nash

Set to local BOOL and then return the BOOL.

Set to local BOOL and then return the BOOL.

2:31 pm

Sean Nash

Make a #define up top for the 5.

Make a #define up top for the 5.

2:30 pm

Sean Nash

Initialize this in the init function instead of here.

Initialize this in the init function instead of here.

2:29 pm

Vendor - TEL - Vijay Pamula

Yes,I Added the Dial-in override function for the publish interval.

Yes,I Added the Dial-in override function for the publish interval.

2:27 pm

Vendor - TEL - Vijay Pamula

LDT-4031: Addressed review comments

Options
    • -9
    • +11
    ./ModePreTreat.h
  2. … 1 more file in changeset.
10:43 am

Sean Nash

Are we going to allow Dialin to override this publish interval?

Are we going to allow Dialin to override this publish interval?

10:42 am

Sean Nash

Add a blank line before return statement.

Add a blank line before return statement.

10:41 am

Sean Nash

Try to initialize these broadcast timer counters to different values (between 0 and 19) so that we don't broadcast all data messages at the same time - we want to spread these broadcasts out over e...

Try to initialize these broadcast timer counters to different values (between 0 and 19) so that we don't broadcast all data messages at the same time - we want to spread these broadcasts out over each 1 second period of time.

10:31 am

Sean Nash

Set "Stops" property back to TRUE like the other reserved UI alarms.

Set "Stops" property back to TRUE like the other reserved UI alarms.