Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add to inputs : heparinSetupResumeRequested

Add to inputs : heparinSetupResumeRequested

Add @alarm

Add @alarm

Add to inputs : interruptedPreTxHeparinSetupState

Add to inputs : interruptedPreTxHeparinSetupState

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 2 more files in changeset.
space allignment2

space allignment

Corrected in latest commit

Corrected in latest commit

Staging Sync and resolve issues

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

Can we please break this line as to match our standard of 100 columns? SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL, currentAirPumpPowerLevel, getU32OverrideValue( &currentAirPumpRPM ) );

Can we please break this line as to match our standard of 100 columns?

SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL,
currentAirPumpPowerLevel,
getU32OverrideValue( &currentAirPumpRPM ) );

Set "Stops" property back to TRUE like the other reserved UI alarms.

Set "Stops" property back to TRUE like the other reserved UI alarms.

Updated

Updated

break this line

break this line

add an empty else block after the last else if block in these functions handlePreTxHeparinPreloadState handlePreTxHeparinAwaitSyringeLoadConfirmationState handlePreTxHeparinSeekState handlePreTxHep...

add an empty else block after the last else if block in these functions
handlePreTxHeparinPreloadState
handlePreTxHeparinAwaitSyringeLoadConfirmationState
handlePreTxHeparinSeekState
handlePreTxHeparinPrimeState
handlePreTxHeparinBolusState

break this line

break this line

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

Align all the function comments

Align all the function comments

Delete this row.

Delete this row.

staging sync

the function call seems returning U16. Type cast to U32.

the function call seems returning U16. Type cast to U32.

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?

I think ( setTxDur - preStop ) should be changed to ( preStop ). Also, I think preStop should be renamed to hepDurMin.

I think ( setTxDur - preStop ) should be changed to ( preStop ).
Also, I think preStop should be renamed to hepDurMin.

Can we remote this TODO comment?

Can we remote this TODO comment?

Remove blank line.

Remove blank line.