Activity leahi-dialin/leahi_dialin/td/modules/ejector.py

1:21 pm

Raghu Kallala

More
LEAHI-DIALIN-LDT-5482-1
finished reviewing

10:42 am

Zoltan Miskolci

We will need to get the event_id first, to know how to process the content as Operation status content is different from rest. So this line is just for getting the event id, and based on the resul...

We will need to get the event_id first, to know how to process the content as Operation status content is different from rest.

So this line is just for getting the event id, and based on the result, process the rest into the correct variables

10:40 am

Zoltan Miskolci

removed

10:05 am

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-5482-1
commented on review

remove if we are sure about the message ID

10:02 am

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-5482-1
commented on review

Will we need this after adding the below code?

1:29 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-5482-1
started review

LEAHI-DIALIN-LDT-5482_[Dry Self Test] Update the module to match the current dev changes

9:34 am

Zoltan Miskolci

3:36 pm

Zoltan Miskolci

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

3:07 pm

Raghu Kallala

More
LEAHI-DIALIN-LDT-5152-1
finished reviewing

2:29 pm

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-5152-1
commented on review

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

3:49 pm

Zoltan Miskolci

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update. For more ...

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

10:21 pm