td-firmware / firmware / App / Controllers

Valves.c

Clone Tools

Stats

Commits this week: 5
Total Committers: 5
Last Commit: 18 Aug
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Aug
4:38 pm

Michael Garthwaite and Sean Nash

2:33 pm

Sean Nash

Doesn't look fixed. 717 and 732 are swapped (and so out of order). This array should be in order by rank.

Doesn't look fixed. 717 and 732 are swapped (and so out of order). This array should be in order by rank.

2:20 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:19 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:18 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:18 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, Fixed

Yes, Fixed

2:18 pm

Vendor - TEL - Varshini Nagabooshanam

Agree Fixed

Agree Fixed

2:13 pm

Vendor - TEL - Varshini Nagabooshanam

No fixed

No fixed

2:12 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

This was merge issue earlier at that time I commented out and I forget to uncomment Fixed

This was merge issue earlier at that time I commented out and I forget to uncomment
Fixed

2:10 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:06 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:04 pm

Vendor - TEL - Varshini Nagabooshanam

Prime is not in staging, thats why I added to confirm RX, I will fix that to prime state

Prime is not in staging, thats why I added to confirm RX, I will fix that to prime state

1:57 pm

Sean Nash

Don't we need to go to prime state after dry self-tests are done?

Don't we need to go to prime state after dry self-tests are done?

1:50 pm

Sean Nash

TaskGeneral is included twice. Remove this one.

TaskGeneral is included twice. Remove this one.

1:38 pm

Sean Nash

Remove {} in case if not necessary (i.e. no local variables).

Remove {} in case if not necessary (i.e. no local variables).

1:37 pm

Sean Nash

Remove blank line.

Remove blank line.

1:30 pm

Sean Nash

Keep a blank line between library includes and normal includes.

Keep a blank line between library includes and normal includes.

1:30 pm

Sean Nash

Why?

Why?

1:29 pm

Sean Nash

Why?

Why?

1:29 pm

Michael Garthwaite

Please align the ranking in order

Please align the ranking in order

1:29 pm

Sean Nash

Why commented out?

Why commented out?

1:28 pm

Sean Nash

Align comments.

Align comments.

1:28 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:27 pm

Sean Nash

This should be 2 lines like the one below.

This should be 2 lines like the one below.

Monday 17 Aug
4:58 pm

Sean Nash

11:35 am

Vendor - TEL - Varshini Nagabooshanam

11:32 am

Vendor - TEL - Arpita Srivastava and Sean Nash

10:57 am

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed