Activity dd-firmware/firmware/App/Modes/FPModes/FPModeStandby.c

1:33 pm

Dara Navaei

More
e08f4a0
changed 7 files
LDT-5470-post-treatment---fw-implementat, staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./FPModeStandby.c
- History
- Source
- Diff
./FPModeStandby.c
… 6 more files in changeset.

1:32 pm

Vendor - TEL - Suresh Dharnala

11:50 am

Michael Garthwaite and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-4049-1
finished reviewing

11:41 am

Vendor - TEL - Suresh Dharnala

More
ce35259
changed 1 file
LDT-4049-standby---fw-implementation---2, LDT-5470-post-treatment---fw-implementat, staging LEAHI-DD-FIRMWARE-LDT-4049-1

LDT-4049: Update FP Standby featured logic

- -12
- +8
./FPModeStandby.c
- History
- Source
- Diff
./FPModeStandby.c

1:40 pm

Michael Garthwaite

More
Re: LEAHI-DD-FIRMWARE-LDT-4049-1
commented on review

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

4:59 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-5209-3
started review

LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:

9:21 am

Vendor - TEL - Suresh Dharnala

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the inte...

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

9:13 am

Vendor - TEL - Suresh Dharnala

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic plac...

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

11:05 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-4873-2
started review

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault

9:54 pm

suresh

More
32b198b
changed 3 files
LDT-4049-standby---fw-implementation---2, LDT-5470-post-treatment---fw-implementat, staging LEAHI-DD-FIRMWARE-LDT-4049-1

addressed review comments

- -10
- +20
./FPModeStandby.c
- History
- Source
- Diff
./FPModeStandby.c
… 2 more files in changeset.

2:22 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4049-1
commented on review

you need to bring in the new set of valves here as well.

2:21 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4049-1
commented on review

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

2:15 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4049-1
commented on review

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode b...

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

1:43 pm