td-firmware / firmware / App / Modes

StatePreTxRecirculate.c

Clone Tools

Stats

Commits this week: 6
Total Committers: 4
Last Commit: 19 Aug
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Sean Nash

Why are we commenting this out?

Why are we commenting this out?

2 hrs ago

Sean Nash

Magic number. Make a #define. Should this command be sent here or in transition function of pre-tx mode?

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

3 hrs ago

Sean Nash

Why are we ending air trap control here?

Why are we ending air trap control here?

3 hrs ago

Sean Nash

Why is this commented out?

Why is this commented out?

3 hrs ago

Sean Nash

Add one more blank line before test support banner.

Add one more blank line before test support banner.

3 hrs ago

Sean Nash

Remove these blank lines.

Remove these blank lines.

Wednesday 19 Aug
2:02 pm

Vendor - TEL - Vijay Pamula

10:42 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./StatePreTxRecirculate.c
  2. … 5 more files in changeset.
10:13 am

Vendor - TEL - Arpita Srivastava and Sean Nash

Tuesday 18 Aug
2:30 pm

Vendor - TEL - Vijay Pamula

LDT-5363:Addressed review comments

Options
    • -2
    • +2
    ./StatePreTxRecirculate.c
11:35 am

Vendor - TEL - Arpita Srivastava

Add initialBloodFlowComplete to outputs

Add initialBloodFlowComplete to outputs

11:35 am

Vendor - TEL - Arpita Srivastava

Add initialBloodFlowComplete and preTxRecircStartTime to inputs.

Add initialBloodFlowComplete and preTxRecircStartTime to inputs.

Monday 17 Aug
2:19 pm

Vendor - TEL - Vijay Pamula

LDT-5363:Updated Recirculation State

Options
    • -11
    • +42
    ./StatePreTxRecirculate.c
1:13 pm

Sean Nash

Should be only one return at end of function.

Should be only one return at end of function.

1:13 pm

Sean Nash

I think != TRUE is better in these cases.

I think != TRUE is better in these cases.

1:10 pm

Sean Nash

Should be "brief". No "s".

Should be "brief". No "s".

11:20 am

Vendor - TEL - Vijay Pamula

LDT-5363: Updated Qd logic in Pre-Treatment

Options
    • -1
    • +0
    ./StatePreTxRecirculate.c
  2. … 5 more files in changeset.
Friday 14 Aug
1:03 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-5363_Pre-Treatment - FW Implementation - 11/6:
LEAHI-TD-FIRMWARE-LDT-5363_Pre-Treatment - FW Implementation - 11/6:
Thursday 16 Jul
3:02 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3992_Disposable Tube Set Auto Priming Process - Saline - FW Implementation - 1/6:
LEAHI-TD-FIRMWARE-LDT-3992_Disposable Tube Set Auto Priming Process - Saline - FW Implementation - 1/6:
Monday 22 Jun
9:16 am

Vendor - TEL - Vijay Pamula

Wednesday 17 Jun
12:03 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./StatePreTxRecirculate.c
  2. … 4 more files in changeset.
Friday 12 Jun
11:07 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

2:03 pm

Vendor - TEL - Arpita Srivastava

align the comment part

align the comment part

10:45 am

Sean Nash

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now. For now, comment out this line with a TODO to restore when patient connectio...

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now.
For now, comment out this line with a TODO to restore when patient connection state is implemented and add a temporary line of code to request treatment mode here.

Thursday 11 Jun
4:53 pm

Vendor - TEL - Vijay Pamula

LDT-4027:Updated Pre-treatment Recirculate state

Options
    • -3
    • +3
    ./StatePreTxRecirculate.c
  2. … 2 more files in changeset.
3:10 pm

Vendor - TEL - Vijay Pamula

LDT-4027: Addressed Code review comments for Pre-Treatment Recirculate State

Options
    • -9
    • +6
    ./StatePreTxRecirculate.c
Tuesday 09 Jun
2:38 pm

Sean Nash

You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

2:36 pm

Sean Nash

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

9:52 am

Vendor - TEL - Arpita Srivastava

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested Remove from output: recircMediumAlarmGiven and recircResumeRequested

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested
Remove from output: recircMediumAlarmGiven and recircResumeRequested

9:50 am

Vendor - TEL - Arpita Srivastava

Output should be none.

Output should be none.