leahi-dialin / leahi_dialin / fp

filtration_purification.py

Clone Tools

Stats

Commits this week: 2
Total Committers: 3
Last Commit: 19 Aug
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
58 mins ago

Zoltan Miskolci

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process. Not everyone have acces...

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process.
Not everyone have access to that folder and a whl file don't need to run the update every time, it's more like for those who develop the code.

Also if it's not at the very beginning, the enums will be processed in the next imports, and updating them afterwards is meaningless as it won't reflect in the running code. The files needs to be updated before any other object tries to call them to make an instance.

Wednesday 19 Aug
10:34 pm

Michael Garthwaite

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call....

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call.

suggest keeping the call in if _name_ == '_main_': of enum_update and running that

Tuesday 18 Aug
11:45 am

Raghu Kallala

11:24 am

Dara Navaei

LEAHI-DIALIN-LDT-5615_[Dialin] Update Priming related data for auto-priming service
LEAHI-DIALIN-LDT-5615_[Dialin] Update Priming related data for auto-priming service
Thursday 13 Aug
10:37 am

Zoltan Miskolci

fixed

fixed

9:57 am

Raghu Kallala

Fix typo

Fix typo

Tuesday 11 Aug
2:59 pm

Dara Navaei

LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin
LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin
9:34 am

Zoltan Miskolci

Monday 10 Aug
3:36 pm

Zoltan Miskolci

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

3:07 pm

Raghu Kallala

2:29 pm

Raghu Kallala

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

Friday 07 Aug
3:49 pm

Zoltan Miskolci

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update. For more ...

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

Thursday 06 Aug
10:21 pm

Michael Garthwaite

10:10 pm

Michael Garthwaite

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

Monday 20 Jul
12:34 pm

Dara Navaei

LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor
LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor
Monday 22 Jun
2:55 pm

Zoltan Miskolci

1:00 pm

Vinayakam Mani and Michael Garthwaite

Thursday 18 Jun
4:34 pm

Zoltan Miskolci

Please consult the FW-SW integration xls file for MSG_ID reservations. Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritt...

Please consult the FW-SW integration xls file for MSG_ID reservations.
Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritten by reserved ones.

9:40 am

Michael Garthwaite

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

9:17 am

Dara Navaei

LEAHI-DIALIN-LDT-4732_(Dialin) Dialin version should be included in the all system logs
LEAHI-DIALIN-LDT-4732_(Dialin) Dialin version should be included in the all system logs
Monday 01 Jun
4:20 pm

Zoltan Miskolci

8:01 am

Raghu Kallala

Friday 29 May
10:05 am

Michael Garthwaite

Thursday 21 May
5:09 pm

Zoltan Miskolci

references to Denali has been removed

references to Denali has been removed

7:44 am

Raghu Kallala

Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

Monday 04 May
5:46 pm

Dara Navaei

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
Friday 10 Apr
10:20 am

Zoltan Miskolci

Thursday 09 Apr
3:20 pm

Raghu Kallala and Michael Garthwaite

3:00 pm

Dara Navaei

LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
Wednesday 08 Apr
11:26 am

Zoltan Miskolci