td-firmware / firmware / App / Controllers

AirPump.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 19 Aug
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 20 Aug
11:21 am

Sean Nash

Why are we commenting this out?

Why are we commenting this out?

11:19 am

Sean Nash

Magic number. Make a #define. Should this command be sent here or in transition function of pre-tx mode?

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

10:16 am

Sean Nash

Why are we ending air trap control here?

Why are we ending air trap control here?

9:59 am

Sean Nash

Why is this commented out?

Why is this commented out?

9:46 am

Sean Nash

Add one more blank line before test support banner.

Add one more blank line before test support banner.

9:41 am

Sean Nash

Remove these blank lines.

Remove these blank lines.

Monday 17 Aug
5:01 pm

Sean Nash

5:00 pm

Sean Nash

Thursday 13 Aug
1:00 pm

Vendor - TEL - Vijay Pamula

11:15 am

Sean Nash and Vendor - TEL - Arpita Srivastava

9:53 am

Vendor - TEL - Arpita Srivastava

Add to inputs : heparinSetupResumeRequested

Add to inputs : heparinSetupResumeRequested

9:51 am

Vendor - TEL - Arpita Srivastava

Add @alarm

Add @alarm

9:47 am

Vendor - TEL - Arpita Srivastava

Add to inputs : interruptedPreTxHeparinSetupState

Add to inputs : interruptedPreTxHeparinSetupState

Wednesday 12 Aug
10:26 am

Sean Nash

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

10:25 am

Sean Nash

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

10:21 am

Sean Nash

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Friday 07 Aug
5:07 pm

Vinayakam Mani and Vendor - TEL - Arpita Srivastava

1:52 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Corrected in latest commit

Corrected in latest commit

Wednesday 05 Aug
12:45 pm

Sean Nash

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

Tuesday 04 Aug
11:10 am

Vendor - TEL - Arpita Srivastava

Can we please break this line as to match our standard of 100 columns? SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL, currentAirPumpPowerLevel, getU32OverrideValue( &currentAirPumpRPM ) );

Can we please break this line as to match our standard of 100 columns?

SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL,
currentAirPumpPowerLevel,
getU32OverrideValue( &currentAirPumpRPM ) );

Thursday 30 Jul
10:31 am

Sean Nash

Set "Stops" property back to TRUE like the other reserved UI alarms.

Set "Stops" property back to TRUE like the other reserved UI alarms.

Wednesday 29 Jul
2:35 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

Tuesday 28 Jul
2:47 pm

Vendor - TEL - Arpita Srivastava

break this line

break this line

2:39 pm

Vendor - TEL - Arpita Srivastava

add an empty else block after the last else if block in these functions handlePreTxHeparinPreloadState handlePreTxHeparinAwaitSyringeLoadConfirmationState handlePreTxHeparinSeekState handlePreTxHep...

add an empty else block after the last else if block in these functions
handlePreTxHeparinPreloadState
handlePreTxHeparinAwaitSyringeLoadConfirmationState
handlePreTxHeparinSeekState
handlePreTxHeparinPrimeState
handlePreTxHeparinBolusState

2:32 pm

Vendor - TEL - Arpita Srivastava

break this line

break this line

10:44 am

Vendor - TEL - Arpita Srivastava

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

10:42 am

Vendor - TEL - Arpita Srivastava

Align all the function comments

Align all the function comments

10:19 am

Vendor - TEL - Arpita Srivastava

Delete this row.

Delete this row.

Monday 27 Jul
5:09 pm

Vinayakam Mani

the function call seems returning U16. Type cast to U32.

the function call seems returning U16. Type cast to U32.

Sunday 26 Jul
8:37 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?