dd-firmware / firmware / App / Controllers

BalancingChamber.c

Clone Tools

Stats

Commits this week: 4
Total Committers: 4
Last Commit: 11 Dec
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Dec
2:27 pm

Sean Nash

This function has an output.

This function has an output.

2:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

Thursday 11 Dec
2:00 pm

Sean Nash

Is this temporary? If so, put a TODO to remove later.

Is this temporary? If so, put a TODO to remove later.

1:59 pm

Sean Nash

Remove extra spaces between { and msg name.

Remove extra spaces between { and msg name.

1:58 pm

Sean Nash

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

1:56 pm

Sean Nash

Do these belong in the spent chamber fill group?

Do these belong in the spent chamber fill group?

Tuesday 09 Dec
10:27 am

Sean Nash

Shouldn't EVERY state set ALL valves?

Shouldn't EVERY state set ALL valves?

Monday 08 Dec
7:02 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

7:00 pm

Vendor - TEL - Sameer Poyil

Let public function on top

Let public function on top

6:53 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

6:52 pm

Vendor - TEL - Sameer Poyil

Mixing static and public function , let public function comes on top

Mixing static and public function , let public function comes on top

6:50 pm

Vendor - TEL - Sameer Poyil

comment should start with capital letter

comment should start with capital letter

2:52 pm

Vinayakam Mani

These set of valves defined as per system architecture (to make sure all valves initialized as expected).

These set of valves defined as per system architecture (to make sure all valves initialized as expected).

2:50 pm

Vinayakam Mani

Done.

Done.

2:48 pm

Vinayakam Mani

Done.

Done.

2:48 pm

Vinayakam Mani

Done.

Done.

2:48 pm

Vinayakam Mani

Done.

Done.

2:47 pm

Vinayakam Mani

I would prefer to keep it here, as the start state (DRY_BICART_START_STATE) is always executed when the fill bicart flag (dryBiCartFillRequested) is not set. There are other execs, say fill chamber...

I would prefer to keep it here, as the start state (DRY_BICART_START_STATE) is always executed when the fill bicart flag (dryBiCartFillRequested) is not set. There are other execs, say fill chamber (execBicarbChamberFillMode) mode controls D80 in its sub states. So, not two execs controlling same valve. Once we identified where all modes using these execs, will come up with signals to avoid such scenarios.

2:41 pm

Vinayakam Mani

Done.

Done.

2:40 pm

Vinayakam Mani

Done

Done

2:40 pm

Vinayakam Mani

Done

Done

2:40 pm

Vinayakam Mani

Done.

Done.

Friday 05 Dec
1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -4
    • +4
    ./BalancingChamber.c
  2. … 121 more files in changeset.
Thursday 04 Dec
11:37 am

Sean Nash

Why FP? I don't see FP prefixed s/w faults in the enum.

Why FP? I don't see FP prefixed s/w faults in the enum.

11:27 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

Friday 21 Nov
9:14 am

Sean Nash

Why does this case manage so many more valves than other cases?

Why does this case manage so many more valves than other cases?

9:13 am

Sean Nash

Why not D64 in this case?

Why not D64 in this case?

9:10 am

Sean Nash

Should D64 also be in the #ifndef below? The DryBiCart state machine controls this valve too.

Should D64 also be in the #ifndef below? The DryBiCart state machine controls this valve too.

9:06 am

Sean Nash

Can't we just do all of this in the start state?

Can't we just do all of this in the start state?

9:04 am

Sean Nash

We can abbreviate things in function and variable names, but in descriptive text we should write things out in complete words as this text goes into SDD document.

We can abbreviate things in function and variable names, but in descriptive text we should write things out in complete words as this text goes into SDD document.