Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

align the comment

align the comment

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

arrange this code and new sensor code in a group- line 131 - 142

arrange this code and new sensor code in a group- line 131 - 142

I think we need a #ifdef TEENSY macro ?

I think we need a #ifdef TEENSY macro ?

Need two spaces before the test function

Need two spaces before the test function

It is there in line 131

It is there in line 131

Yes. updated.

Yes. updated.

This is already initialized (properly) near top of function. It is not proper (zero) here.

This is already initialized (properly) near top of function. It is not proper (zero) here.

Is there going to be an #else for new sensor?

Is there going to be an #else for new sensor?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Align comments.

Align comments.

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

Add space between } and type name.

Add space between } and type name.

Indenting looks off for most fields in this struct.

Indenting looks off for most fields in this struct.

Why doesn't name and comment match?

Why doesn't name and comment match?

Fixed it

Fixed it

Ya , I forgot the coding guide line . Fixed it

Ya , I forgot the coding guide line .
Fixed it

fixed it

fixed it

Fixed it

Fixed it

fixed it

fixed it

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

Remove extra blank line.

Remove extra blank line.

I don't think we need to check test config for variable initialization.

I don't think we need to check test config for variable initialization.