dd-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 12
Total Committers: 14
Last Commit: 11 Dec 25
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Feb
9:10 pm

Vendor - TEL - Sameer Poyil

seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

9:07 pm

Vendor - TEL - Sameer Poyil

align the comment

align the comment

9:06 pm

Vendor - TEL - Sameer Poyil

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

7:45 pm

Vendor - TEL - Sameer Poyil

Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

7:22 pm

Vendor - TEL - Sameer Poyil

arrange this code and new sensor code in a group- line 131 - 142

arrange this code and new sensor code in a group- line 131 - 142

7:19 pm

Vendor - TEL - Sameer Poyil

I think we need a #ifdef TEENSY macro ?

I think we need a #ifdef TEENSY macro ?

7:16 pm

Vendor - TEL - Sameer Poyil

Need two spaces before the test function

Need two spaces before the test function

7:14 pm

Vendor - TEL - Sameer Poyil

It is there in line 131

It is there in line 131

5:04 pm

Vinayakam Mani

Yes. updated.

Yes. updated.

2:03 pm

Sean Nash

This is already initialized (properly) near top of function. It is not proper (zero) here.

This is already initialized (properly) near top of function. It is not proper (zero) here.

2:01 pm

Sean Nash

Is there going to be an #else for new sensor?

Is there going to be an #else for new sensor?

1:59 pm

Sean Nash

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

1:58 pm

Sean Nash

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Will new conductivity sensor driver have this override too? It looks Teensy specific.

1:12 pm

Sean Nash

Align comments.

Align comments.

1:11 pm

Sean Nash

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

1:09 pm

Sean Nash

Add space between } and type name.

Add space between } and type name.

1:08 pm

Sean Nash

Indenting looks off for most fields in this struct.

Indenting looks off for most fields in this struct.

1:07 pm

Sean Nash

Why doesn't name and comment match?

Why doesn't name and comment match?

9:25 am

Sean Nash

Friday 06 Feb
7:35 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Ya , I forgot the coding guide line . Fixed it

Ya , I forgot the coding guide line .
Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:32 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:56 pm

Sean Nash

2:22 pm

Sean Nash

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

2:17 pm

Sean Nash

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

10:52 am

Sean Nash

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

10:51 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:26 am

Vinayakam Mani

I don't think we need to check test config for variable initialization.

I don't think we need to check test config for variable initialization.