td-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 3
Total Committers: 9
Last Commit: 22 Jan 25
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 27 Jun
9:11 am

Sean Nash

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Friday 26 Jun
3:16 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

Wednesday 24 Jun
2:42 pm

Vendor - TEL - Arpita Srivastava

please add message id.

please add message id.

2:34 pm

Sean Nash

We should set all TD actuators here, not just blood pump.

We should set all TD actuators here, not just blood pump.

2:28 pm

Vendor - TEL - Arpita Srivastava

please remove extra line

please remove extra line

2:26 pm

Vendor - TEL - Arpita Srivastava

Output is none

Output is none

2:23 pm

Vendor - TEL - Arpita Srivastava

Please add message id.

Please add message id.

2:22 pm

Vendor - TEL - Arpita Srivastava

Output is none

Output is none

2:21 pm

Vendor - TEL - Arpita Srivastava

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

1:14 pm

Sean Nash

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

1:00 pm

Sean Nash

Change "SetupConnection" to "SetupTubingSetConnection"

Change "SetupConnection" to "SetupTubingSetConnection"

12:59 pm

Sean Nash

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Monday 22 Jun
5:39 pm

Sean Nash

Can we restore this code?

Can we restore this code?

5:36 pm

Sean Nash

Remove FANS test.

Remove FANS test.

5:34 pm

Sean Nash

Remove.

Remove.

5:33 pm

Sean Nash

Move this to Messaging.c

Move this to Messaging.c

5:32 pm

Sean Nash

Remove. Replaced by generic confirmation functions and messages.

Remove. Replaced by generic confirmation functions and messages.

5:30 pm

Sean Nash

Remove this function - replaced by generic confirmation functions.

Remove this function - replaced by generic confirmation functions.

5:28 pm

Sean Nash

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirm...

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirmation flag.

5:24 pm

Sean Nash

Replace with request code above.

Replace with request code above.

5:23 pm

Sean Nash

Remove this function after you've moved what we need.

Remove this function after you've moved what we need.

5:23 pm

Sean Nash

No need for these elses.

No need for these elses.

5:22 pm

Sean Nash

Remove send function call.

Remove send function call.

5:22 pm

Sean Nash

Move this code inside if statement to handleOffButtonProcessing() where same if statement exists.

Move this code inside if statement to handleOffButtonProcessing() where same if statement exists.

5:21 pm

Sean Nash

No need to move else - not needed.

No need to move else - not needed.

5:20 pm

Sean Nash

Replace this send function call with addConfirmationRequest()

Replace this send function call with addConfirmationRequest()

5:19 pm

Sean Nash

Move this if down to handleOffButtonProcessing()

Move this if down to handleOffButtonProcessing()

4:58 pm

Sean Nash

Add a confirmation for power off.

Add a confirmation for power off.

4:57 pm

Sean Nash

Remove B7 msg ID. Not needed.

Remove B7 msg ID. Not needed.

4:37 pm

Sean Nash

Use new generic confirmation approach.

Use new generic confirmation approach.