dd-firmware / firmware / App / Modes

ModeGenDialysate.h

Clone Tools

Stats

Commits this week: 4
Total Committers: 10
Last Commit: 15 Nov 24
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 10 Apr
3:01 pm

Vendor - TEL - Jashwant Gantyada

1:42 pm

Vinayakam Mani and Sean Nash

11:52 am

Vinayakam Mani

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

8:21 am

Raghu Kallala

You are right, modified in all places

You are right, modified in all places

Wednesday 08 Apr
1:51 pm

Sean Nash

FALSE?

FALSE?

1:51 pm

Sean Nash

FALSE?

FALSE?

1:50 pm

Sean Nash

FALSE?

FALSE?

1:46 pm

Sean Nash

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

1:44 pm

Sean Nash

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

1:41 pm

Sean Nash

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

11:14 am

Vinayakam Mani

Delete the macro if not being used.

Delete the macro if not being used.

8:24 am

Dara Navaei

Tuesday 07 Apr
2:54 pm

Vinayakam Mani

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

Monday 06 Apr
2:13 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

2:13 pm

Vendor - TEL - Jashwant Gantyada

updated comment.

updated comment.

2:12 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

2:12 pm

Vendor - TEL - Jashwant Gantyada

removed and added comments.

removed and added comments.

2:12 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

2:12 pm

Vendor - TEL - Jashwant Gantyada

done. moved them to dosing concentrates state.

done. moved them to dosing concentrates state.

1:00 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
12:45 pm

Raghu Kallala

10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

10:22 am

Vinayakam Mani

Remove this reference (across the file) if the implementation is updated.

Remove this reference (across the file) if the implementation is updated.

10:17 am

Vinayakam Mani

Update the deadband timing in the comments.

Update the deadband timing in the comments.

10:15 am

Vinayakam Mani

Remove blank line. Also, add comments on the key logics for reference.

Remove blank line. Also, add comments on the key logics for reference.

10:08 am

Vinayakam Mani

Default case rise count should be 2, instead of 1?

Default case rise count should be 2, instead of 1?

10:05 am

Vinayakam Mani

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

9:36 am

Vinayakam Mani

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.