td-firmware

Clone Tools

Stats

Commits this week: 30
Total Committers: 17
Last Commit: 24 Feb 25
Commits this week: 30

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
39 mins ago

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

39 mins ago

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

Tuesday 09 Jun
4:44 pm

Sean Nash

Change PRES_OCCL to PRESSURE

Change PRES_OCCL to PRESSURE

4:43 pm

Sean Nash

Maybe move OperationModes.c?

Maybe move OperationModes.c?

4:42 pm

Sean Nash

Use generic confirmation functions/messages.

Use generic confirmation functions/messages.

4:41 pm

Sean Nash

Move this function to OperationModes.c.

Move this function to OperationModes.c.

4:40 pm

Sean Nash

From here forward, we can just call sendMessage() with appropriate params.

From here forward, we can just call sendMessage() with appropriate params.

4:37 pm

Sean Nash

Use generic helper function (sendMessage) in MessageSupport.c.

Use generic helper function (sendMessage) in MessageSupport.c.

4:33 pm

Sean Nash

Use generic confirmation functions/messages for off button.

Use generic confirmation functions/messages for off button.

4:26 pm

Sean Nash

Remove change.

Remove change.

2:38 pm

Sean Nash

You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

2:36 pm

Sean Nash

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

10:19 am

Vendor - TEL - Arpita Srivastava

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input. Then you will not need all thes...

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input.
Then you will not need all these repetitive functions:
isSystolicBpLowAlarmLimitValid
isSystolicBpHighAlarmLimitValid
isHeartRateLowAlarmLimitValid
isHeartRateHighAlarmLimitValid

Similarly, you can create another function with input as TREATMENT_PARAM_T minValue and TREATMENT_PARAM_T maxValue for isVitalsMeasurementIntervalValid()

10:05 am

Vendor - TEL - Arpita Srivastava

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

9:52 am

Vendor - TEL - Arpita Srivastava

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested Remove from output: recircMediumAlarmGiven and recircResumeRequested

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested
Remove from output: recircMediumAlarmGiven and recircResumeRequested

9:50 am

Vendor - TEL - Arpita Srivastava

Output should be none.

Output should be none.

9:36 am

Vendor - TEL - Arpita Srivastava

Just curious, at what condition we leave this state? It looks like, once we enter this state, we stay.

Just curious, at what condition we leave this state?
It looks like, once we enter this state, we stay.

Monday 08 Jun
3:32 pm

Sean Nash

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

3:27 pm

Sean Nash

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

3:08 pm

Sean Nash

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).

3:04 pm

Sean Nash

It doesn't look like these memsets are necessary. Consider removing them.

It doesn't look like these memsets are necessary. Consider removing them.

3:03 pm

Sean Nash

Remove blank line.

Remove blank line.

3:02 pm

Sean Nash

Can you move this down with the other vitals functions?

Can you move this down with the other vitals functions?

2:33 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4149_Pinch Valves - FW Implementation - 1/1:
LEAHI-TD-FIRMWARE-LDT-4149_Pinch Valves - FW Implementation - 1/1:
11:20 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
Friday 05 Jun
4:14 pm

Sean Nash

Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

4:13 pm

Sean Nash

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

4:13 pm

Sean Nash

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

4:10 pm

Sean Nash

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

4:08 pm

Sean Nash

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.