TxParams.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input. Then you will not need all thes...

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input.
Then you will not need all these repetitive functions:
isSystolicBpLowAlarmLimitValid
isSystolicBpHighAlarmLimitValid
isHeartRateLowAlarmLimitValid
isHeartRateHighAlarmLimitValid

Similarly, you can create another function with input as TREATMENT_PARAM_T minValue and TREATMENT_PARAM_T maxValue for isVitalsMeasurementIntervalValid()

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).

It doesn't look like these memsets are necessary. Consider removing them.

It doesn't look like these memsets are necessary. Consider removing them.

Remove blank line.

Remove blank line.

Can you move this down with the other vitals functions?

Can you move this down with the other vitals functions?

LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
Should this check be moved to the fluid bolus exec function?

Should this check be moved to the fluid bolus exec function?

Maintain alphabetical order.

Maintain alphabetical order.

Eliza says we do allow multiple iso UF sessions in a treatment. So do we still need this else if, but looking at <= iso UF elapsed session time?

Eliza says we do allow multiple iso UF sessions in a treatment. So do we still need this else if, but looking at <= iso UF elapsed session time?

What about HDF?

What about HDF?

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is...

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is being handled in this function.

return result;

return result;

Keep local result and set to TRUE or FALSE with a ternary.

Keep local result and set to TRUE or FALSE with a ternary.

Which setting does this message confirm (duration or volume)?

Which setting does this message confirm (duration or volume)?

Align comment.

Align comment.

where are we calling an alarm? i think we are only sending event change data in completeBolusToCumulative() right?

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

do we need this block?

do we need this block?

update the comment as required: ml or L?

update the comment as required: ml or L?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 8 more files in changeset.