dd-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 7
Total Committers: 16
Last Commit: 31 Dec 69
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
10 mins ago

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

27 mins ago

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

28 mins ago

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

54 mins ago

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

1 hr ago

Dara Navaei

Any fault alarm here?

Any fault alarm here?

1 hr ago

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

Wednesday 22 Jul
1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

Monday 20 Jul
4:39 pm

Vinayakam Mani

Delete it.

Delete it.

4:32 pm

Vinayakam Mani

Remove blank spaces after =.

Remove blank spaces after =.

4:31 pm

Vinayakam Mani

To be deleted this line?

To be deleted this line?

4:25 pm

Vinayakam Mani

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as w...

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as well.

4:19 pm

Vinayakam Mani

I guess we can remove the "balancingChamberFillInProgress" check here.

I guess we can remove the "balancingChamberFillInProgress" check here.

10:33 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
Sunday 19 Jul
9:20 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

code re-organisation

Options
    • -1
    • +1
    ./AlarmMgmtDD.c
  2. … 5 more files in changeset.
8:28 am

Vendor - TEL - Sameer Poyil

Friday 17 Jul
1:57 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Initial Changes

Options
    • -1
    • +1
    ./AlarmMgmtDD.c
  2. … 5 more files in changeset.
12:51 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./TDInterface.c
  2. … 4 more files in changeset.
Wednesday 15 Jul
3:04 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4876_(DD) DD intermittently goes into fault mode without populating the last alarm triggered variables
LEAHI-DD-FIRMWARE-LDT-4876_(DD) DD intermittently goes into fault mode without populating the last alarm triggered variables
3:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
9:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
Tuesday 14 Jul
3:06 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./FpgaDD.c
    • -1
    • +1
    ./FpgaDD.h
  3. … 7 more files in changeset.
2:58 pm

Michael Garthwaite

2:43 pm

Sean Nash

Remove blank line.

Remove blank line.

2:42 pm

Sean Nash

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

2:37 pm

Sean Nash

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

2:32 pm

Sean Nash

Add blank line between declarations and rest of function code (throughout this unit)

Add blank line between declarations and rest of function code (throughout this unit)

2:31 pm

Sean Nash

Add blank line before return statement. ( throughout this unit )

Add blank line before return statement. ( throughout this unit )