dd-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 15
Total Committers: 15
Last Commit: 31 Dec 69
Commits this week: 15

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Jun
9:14 am

Sean Nash

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

9:11 am

Sean Nash

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

9:07 am

Sean Nash

Why only these states are valid?

Why only these states are valid?

9:05 am

Sean Nash

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Thursday 11 Jun
2:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AlarmMgmtSWFaults.h
    • -2
    • +2
    ./FpgaDD.c
    • -1
    • +1
    ./FpgaDD.h
    • -2
    • +2
    ./Messaging.c
    • -2
    • +2
    ./TDInterface.c
  6. … 8 more files in changeset.
2:24 pm

Michael Garthwaite

1:27 pm

Vinayakam Mani and Sean Nash

10:10 am

Michael Garthwaite

LDT-4001: code review comments

Options
    • -1
    • +1
    ./Messaging.c
  2. … 1 more file in changeset.
10:08 am

Michael Garthwaite

fixed thanks

fixed thanks

10:00 am

Sean Nash

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

9:59 am

Michael Garthwaite

fixed thanks

fixed thanks

9:59 am

Michael Garthwaite

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

9:58 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

this is a set speed in rpm

this is a set speed in rpm

9:57 am

Michael Garthwaite

this is speed in rpm

this is speed in rpm

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:55 am

Michael Garthwaite

LDT-4001: code review comments

Options
    • -1
    • +1
    ./Messaging.c
    • -3
    • +3
    ./TDInterface.c
  3. … 2 more files in changeset.
9:43 am

Sean Nash

Change speed to rate.

Change speed to rate.

9:43 am

Sean Nash

pumpTargetRate

pumpTargetRate

9:43 am

Sean Nash

Change function name to say rate instead of speed

Change function name to say rate instead of speed

9:42 am

Sean Nash

Is this a rate too?

Is this a rate too?

9:42 am

Sean Nash

Is this a rate too?

Is this a rate too?

9:40 am

Sean Nash

Change speed to rate.

Change speed to rate.

9:40 am

Sean Nash

Is currentPumpSpeed actually a rate?

Is currentPumpSpeed actually a rate?

9:38 am

Sean Nash

Is this comment correct? Seems like we're stopping pump if requested to turn off.

Is this comment correct? Seems like we're stopping pump if requested to turn off.

9:36 am

Sean Nash

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

9:34 am

Sean Nash

Align comment.

Align comment.

9:34 am

Sean Nash

Align comment. Change "speed" to "rate in comment too. Also, I don't see you initializing these rates.

Align comment. Change "speed" to "rate in comment too.
Also, I don't see you initializing these rates.