dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 10
Total Committers: 13
Last Commit: 06 May
Commits this week: 10

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Wednesday 06 May
1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
7:40 am

Vendor - TEL - Jashwant Gantyada

7:39 am

Vendor - TEL - Sameer Poyil

LDT-4183 increasing max drybicart pressure to 20 PSI for beta 2.1

Options
    • -1
    • +1
    ./DryBiCart.c
Tuesday 05 May
3:54 pm

Vendor - TEL - Jashwant Gantyada , Vendor - TEL - Varshini Nagabooshanam and Vinayakam Mani

3:17 pm

Vinayakam Mani

Use the get Acid mix control interval?

Use the get Acid mix control interval?

3:11 pm

Vinayakam Mani

Updates the comments for all new variables.

Updates the comments for all new variables.

12:35 pm

Vinayakam Mani

Remove this flag.

Remove this flag.

12:31 pm

Vinayakam Mani

Remove this code.

Remove this code.

12:30 pm

Vendor - TEL - Varshini Nagabooshanam

There should be a \b before the type of details (Inputs and Outputs here) for documentation please update for all

There should be a \b before the type of details (Inputs and Outputs here) for documentation please update for all

12:30 pm

Vendor - TEL - Varshini Nagabooshanam

Remove blank line

Remove blank line

11:57 am

Vinayakam Mani

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

11:24 am

Vendor - TEL - Varshini Nagabooshanam

Remove blank line There should be a \b before the type of details (Inputs and Outputs here) for documentation

Remove blank line
There should be a \b before the type of details (Inputs and Outputs here) for documentation

11:22 am

Vendor - TEL - Varshini Nagabooshanam

There should be a \b before the type of details (Inputs and Outputs here) for documentation Inputs: None?

There should be a \b before the type of details (Inputs and Outputs here) for documentation
Inputs: None?

11:10 am

Vendor - TEL - Arpita Srivastava and Raghu Kallala

11:10 am

Raghu Kallala and Vendor - TEL - Arpita Srivastava

10:20 am

Vinayakam Mani

Check the else portion and do the required changes.

Check the else portion and do the required changes.

Monday 04 May
4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

7:33 am

Vendor - TEL - Sameer Poyil

LDT-4183 drybicart firmware implementation

Options
    • -6
    • +6
    ./DryBiCart.c
7:22 am

Vendor - TEL - Sameer Poyil

Merge branch LDT-4183-dialysate-composition-dry-bicar into develop

Options
    • -11
    • +112
    ./DryBiCart.c
  2. … 1 more file in changeset.
7:12 am

Vendor - TEL - Sameer Poyil

LDT-4183 addressed self review comments plus dry bicarb implementation

Options
    • -11
    • +107
    ./DryBiCart.c
    • -1
    • +7
    ./DryBiCart.h
Sunday 03 May
11:45 pm

Sean Nash