dd-firmware / firmware / App / Controllers

MixingControl.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 12:00
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
3 hrs ago

Vinayakam Mani

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband co...

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

4 hrs ago

Vinayakam Mani

This should return POST conductivity.

This should return POST conductivity.

4 hrs ago

Vinayakam Mani

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

4 hrs ago

Vinayakam Mani

Init PI Controls missing here.

Init PI Controls missing here.

4 hrs ago

Vinayakam Mani

13734.87F

13734.87F

Monday 22 Jun
12:18 pm

Vinayakam Mani

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5...

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

12:14 pm

Vinayakam Mani

both acid and bicarb mix volume

both acid and bicarb mix volume

12:07 pm

Vinayakam Mani

Add MULTIPLIER at the end.

Add MULTIPLIER at the end.

11:47 am

Vinayakam Mani

Initialize at init function.

Initialize at init function.

11:47 am

Vinayakam Mani

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

11:37 am

Vinayakam Mani

Lets remove this.

Lets remove this.

10:22 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
Sunday 21 Jun
9:16 pm

Vendor - TEL - Sameer Poyil

Tuesday 16 Jun
1:24 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

1:16 pm

Vendor - TEL - Jashwant Gantyada

11:55 am

Vinayakam Mani

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

10:33 am

Vendor - TEL - Sameer Poyil

I will mark it as TODO , so you can close it

I will mark it as TODO , so you can close it

10:24 am

Vinayakam Mani

Update name.

Update name.

10:22 am

Vinayakam Mani

Add a Todo comment to resolve the issue.

Add a Todo comment to resolve the issue.

10:20 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:17 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:15 am

Vinayakam Mani

Do we need these comments? delete it if not required.

Do we need these comments? delete it if not required.

10:11 am

Vinayakam Mani

Align the indent

Align the indent

Monday 15 Jun
2:17 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:16 pm

Vinayakam Mani

Remove unused header files.

Remove unused header files.

2:15 pm

Vinayakam Mani

Remove empty line.

Remove empty line.

2:14 pm

Vinayakam Mani

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

2:11 pm

Vinayakam Mani

Initialize result to open loop state and remove the open loop state assignment later.

Initialize result to open loop state and remove the open loop state assignment later.

12:29 pm

Vinayakam Mani

Remove the blank line

Remove the blank line