Activity dd-firmware/firmware/App/Monitors

1:26 pm

Vendor - TEL - Jashwant Gantyada

More
de5e503
changed 2 files
LDT-4410-dialysate-composition-mixing-2, develop LEAHI-DD-FIRMWARE-LDT-4410-3

LDT-4410 addressed code review comments

- -15
- +6
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 1 more file in changeset.

12:18 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5...

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

12:14 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

both acid and bicarb mix volume

12:07 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Add MULTIPLIER at the end.

11:47 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Initialize at init function.

11:47 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

11:37 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Lets remove this.

10:22 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-4410-3
started review

LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:

10:15 am

Vendor - TEL - Jashwant Gantyada

More
313fa2d
changed 3 files
LDT-4410-dialysate-composition-mixing-2, develop LEAHI-DD-FIRMWARE-LDT-4410-3

LDT-4410 inital code for filter and control interval

- -4
- +76
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 2 more files in changeset.

9:16 pm

Vendor - TEL - Sameer Poyil

2:34 pm

Vendor - TEL - Sameer Poyil

More
ff6b765
changed 7 files
develop

LDT-4409 drybicart firmware implementation and mixing control

- -1
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 6 more files in changeset.

1:37 pm

Dara Navaei

More
145fd71
changed 14 files
LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 13 more files in changeset.

1:35 pm

Vendor - TEL - Sameer Poyil

More
71c51ef
changed 2 files
LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more

LDT-4409 drybicart and dialysate mixing firmware implementation

- -2
- +2
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 1 more file in changeset.

1:24 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-4409-2
resumed reviewing

1:16 pm

Vendor - TEL - Jashwant Gantyada

More
LEAHI-DD-FIRMWARE-LDT-4409-2
joined review

12:49 pm

Dara Navaei

More
3b64586
changed 6 files
LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
- -1
- +1
./Conductivity.h
- History
- Source
- Diff
./Conductivity.h
… 4 more files in changeset.

12:45 pm

Michael Garthwaite

More
359af96
changed 1 file
LDT-4410-dialysate-composition-mixing-2, LDT-4485-dd-conductivity-sensors-d17 and 3 more

LDT-4485: err fix

- -0
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c

12:42 pm

Michael Garthwaite

More
e3dc524
changed 1 file
LDT-4410-dialysate-composition-mixing-2, LDT-4485-dd-conductivity-sensors-d17 and 3 more

LDT-4485: err fix

- -1
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c

12:41 pm

Michael Garthwaite

11:55 am

Vinayakam Mani

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

11:09 am