Activity td-firmware/firmware/App

This command should be given once on way out of prior state instead of every 50ms while in this state. We also need to zero the timer counter at same time so the timeout check below works.

This command should be given once on way out of prior state instead of every 50ms while in this state.
We also need to zero the timer counter at same time so the timeout check below works.

2:03 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

Response needs to be sent immediately (in message handler function). This is too late.

2:02 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

We shouldn't need to do this door check if you've required door be closed for the state. Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed ...

We shouldn't need to do this door check if you've required door be closed for the state.
Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed and call with ( FALSE ) on transition into a state that doesn't require door to be closed. When required = TRUE, the switch monitor will trigger the door open alarm for you.

1:57 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

Same organization comment that I had for post-tx mode. Let's keep functions related to each pre-tx state together separated by some kind of comment banner.

1:56 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

Remove extra blank line.

1:56 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

Looks like there's plans for 4 post-tx states and we only have your auto eject state implemented here below. Since all of these 4 states will be implemented in this file, maybe we should organize t...

Looks like there's plans for 4 post-tx states and we only have your auto eject state implemented here below.
Since all of these 4 states will be implemented in this file, maybe we should organize them - keep functions related to each state together separated by some kind of comment banner.

1:53 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

Not necessary if you give retract command on way out of prior state.

1:52 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

I don't think this if statement is necessary. We wouldn't be in this state if the ejector didn't extend already. I think we just want to see if BP is home again (completed 1 revolution) so we know ...

I don't think this if statement is necessary. We wouldn't be in this state if the ejector didn't extend already.
I think we just want to see if BP is home again (completed 1 revolution) so we know when to stop and go to next state.

1:48 pm