StateServices

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Align =

Align =

Should modality be an enum type?

Should modality be an enum type?

Align =

Align =

Should this be an enum type?

Should this be an enum type?

What is the 3rd modality?

What is the 3rd modality?

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Move after Modes so they are alphabetized.

Move after Modes so they are alphabetized.

Remove extra ;

Remove extra ;

Can we align comments?

Can we align comments?

Missing pinch valves (H1 and H19).

Missing pinch valves (H1 and H19).

Remove this blank line.

Remove this blank line.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

please add message id.

please add message id.

We should set all TD actuators here, not just blood pump.

We should set all TD actuators here, not just blood pump.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

Change "SetupConnection" to "SetupTubingSetConnection"

Change "SetupConnection" to "SetupTubingSetConnection"

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6:
LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6:
Thank you for the clarification!

Thank you for the clarification!

break into two lines

break into two lines

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG