FPModeStandby.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
you need to bring in the new set of valves here as well.

you need to bring in the new set of valves here as well.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode b...

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

Align the indent. Replace RO to FP.

Align the indent. Replace RO to FP.

LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 16 more files in changeset.
Updated

Updated

Added

Added

Add a comment: result already FALSE - do nothing more for modes that do not support jump to sub-mode.

Add a comment:
result already FALSE - do nothing more for modes that do not support jump to sub-mode.

Add a comment here: Do nothing for modes that do not support jump to sub-mode.

Add a comment here:
Do nothing for modes that do not support jump to sub-mode.

LDT-3603 addressed review comments

  1. … 6 more files in changeset.
Updated

Updated

Updated, thanks

Updated, thanks

'genPermeateState' in the outputs. please update across the files as needed.

'genPermeateState' in the outputs. please update across the files as needed.

Validates the requested sub mode change is acceptable or not?

Validates the requested sub mode change is acceptable or not?

LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem
LDT-3603 redo of FP set operation sub mode on a new branch

  1. … 16 more files in changeset.
That's a question for me, will that be required? Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required) Init don't have any and service is not defined yet

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

Updated

Updated

Updated

Updated

Changed and left them as static, as we don't need these outside this unit

Changed and left them as static, as we don't need these outside this unit