dd-firmware / firmware / App / Drivers

BloodLeakDriver.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 1
Last Commit: 30 Jul 24
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Dec
10:17 am

Vendor - TEL - Jashwant Gantyada

I think you are seeing previous commit. It is not there in the present code.

I think you are seeing previous commit. It is not there in the present code.

10:16 am

Vendor - TEL - Jashwant Gantyada

Done. Thank you.

Done. Thank you.

10:15 am

Vendor - TEL - Jashwant Gantyada

Changed. Thank you.

Changed. Thank you.

Wednesday 10 Dec
8:03 pm

Vendor - TEL - Sameer Poyil

is it merge issue ?

is it merge issue ?

7:56 pm

Vendor - TEL - Sameer Poyil

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

7:50 pm

Vendor - TEL - Sameer Poyil

Please bring public functions on top. check it for all function in this file , except test functions

Please bring public functions on top. check it for all function in this file , except test functions

Tuesday 09 Dec
11:21 am

Dara Navaei

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

10:39 am

Sean Nash

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

Friday 05 Dec
8:52 am

Vendor - TEL - Sameer Poyil

structure packing missing

structure packing missing

8:48 am

Vendor - TEL - Sameer Poyil

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Wednesday 26 Nov
10:07 am

Vendor - TEL - Jashwant Gantyada

Removed. Thank you.

Removed. Thank you.

10:07 am

Vendor - TEL - Jashwant Gantyada

Moved the enums to driver header file. Fixed it.

Moved the enums to driver header file. Fixed it.

10:06 am

Vendor - TEL - Jashwant Gantyada

Fixed. Thank you.

Fixed. Thank you.

10:06 am

Vendor - TEL - Jashwant Gantyada

Fixed. Thank you.

Fixed. Thank you.

10:05 am

Vendor - TEL - Jashwant Gantyada

Removed. Thank you.

Removed. Thank you.

10:05 am

Vendor - TEL - Jashwant Gantyada

called it from here. Fixed it. Thank you

called it from here. Fixed it. Thank you

10:04 am

Vendor - TEL - Jashwant Gantyada

fixed. thank you.

fixed. thank you.

10:04 am

Vendor - TEL - Jashwant Gantyada

fixed. thank you.

fixed. thank you.

10:04 am

Vendor - TEL - Jashwant Gantyada

fixed. thank you.

fixed. thank you.

10:04 am

Vendor - TEL - Jashwant Gantyada

fixed. thank you.

fixed. thank you.

10:03 am

Vendor - TEL - Jashwant Gantyada

fixed. thank you.

fixed. thank you.

10:03 am

Vendor - TEL - Jashwant Gantyada

fixed. thank you.

fixed. thank you.

10:03 am

Vendor - TEL - Jashwant Gantyada

fixed. thanks

fixed. thanks

Tuesday 25 Nov
1:41 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:38 pm

Sean Nash

Keep 2 blank lines above/below test banner.

Keep 2 blank lines above/below test banner.

1:37 pm

Sean Nash

Packing only needed if it's used for transmission. I don't see this structure being broadcast anywhere.

Packing only needed if it's used for transmission. I don't see this structure being broadcast anywhere.

1:33 pm

Sean Nash

Remove blank line.

Remove blank line.

1:33 pm

Sean Nash

Do we need to call initBloodLeakDriver() here?

Do we need to call initBloodLeakDriver() here?

1:29 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:29 pm

Sean Nash

If both monitor and driver need visibility to something, consider moving it to the driver's header file since monitor needs to include driver anyway. Driver should not have to know about the monito...

If both monitor and driver need visibility to something, consider moving it to the driver's header file since monitor needs to include driver anyway. Driver should not have to know about the monitor stuff as it is higher level.