Activity dd-firmware/firmware/App/Modes

2 hrs ago

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

2 hrs ago

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

6 hrs ago

Raghu Kallala

6 hrs ago

Sean Nash , Vinayakam Mani and Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-3343-1
finished reviewing

7 hrs ago

Vendor - TEL - Sameer Poyil

Fixed it

11 hrs ago

Raghu Kallala

Updated

11 hrs ago

Raghu Kallala

Fixed

5:23 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

3:12 pm

Vendor - TEL - Sameer Poyil

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

3:00 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3343-1
commented on review

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

2:59 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3343-1
commented on review

Remove blank line.

2:04 pm

Vendor - TEL - Sameer Poyil

It will be fixed in Balancing chamber re-implementation

1:45 pm

Vendor - TEL - Sameer Poyil

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

3:41 pm

Vendor - TEL - Sameer Poyil

fixed it

3:39 pm

Vendor - TEL - Sameer Poyil

fixed it

3:17 pm

Vendor - TEL - Sameer Poyil

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }

The request is cleared here. for consistency I am moving to the end of the fill cycle

2:15 pm