dd-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 14
Total Committers: 13
Last Commit: 30 Jul 24
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Feb
5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

3:12 pm

Vendor - TEL - Sameer Poyil

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

3:00 pm

Sean Nash

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

2:59 pm

Sean Nash

Remove blank line.

Remove blank line.

2:04 pm

Vendor - TEL - Sameer Poyil

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

1:45 pm

Vendor - TEL - Sameer Poyil

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

12:53 pm

Michael Garthwaite

Monday 02 Feb
3:41 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:39 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:17 pm

Vendor - TEL - Sameer Poyil

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle

2:15 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
2:02 pm

Sean Nash

Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

1:55 pm

Sean Nash

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

11:37 am

Michael Garthwaite

11:01 am

Sean Nash

10:55 am

Sean Nash

Remove blank line.

Remove blank line.

10:55 am

Sean Nash

Add a blank line before return statement.

Add a blank line before return statement.

10:52 am

Sean Nash

Why is this commented out?

Why is this commented out?

10:51 am

Sean Nash

d48PumpSpeed is an input.

d48PumpSpeed is an input.

10:37 am

Michael Garthwaite

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:49 am

Sean Nash

What should trimmer heater be doing in these spent/bicarb chamber states?

What should trimmer heater be doing in these spent/bicarb chamber states?

9:41 am

Sean Nash

I would think this would be enabled by default.

I would think this would be enabled by default.

9:29 am

Sean Nash

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

9:28 am

Sean Nash

Should there be any constraints to setting these request flags to TRUE? What if drain request is still in progress for example? Shouldn't drain finish before fill starts? This wouldn't be an issue ...

Should there be any constraints to setting these request flags to TRUE? What if drain request is still in progress for example? Shouldn't drain finish before fill starts?
This wouldn't be an issue if we combined the 3 state machines.

Friday 30 Jan
10:14 pm

Vendor - TEL - Sameer Poyil

Complex conditional expressions can be avoided. Introduce temporary boolean variables instead. for example if ((elementNo < 0) || (elementNo > maxElement)|| elementNo == lastElement){ … } should b...

Complex conditional expressions can be avoided. Introduce
temporary boolean variables instead.

for example
if ((elementNo < 0) || (elementNo > maxElement)||
elementNo == lastElement)

Unknown macro: { … }


should be replaced by:
isFinished = (elementNo < 0) || (elementNo > maxElement);
isRepeatedEntry = elementNo == lastElement;
if ((isFinished == TRUE) || (isRepeatedEntry == TRUE))

4:32 pm

Vendor - TEL - Sameer Poyil

its rate , pump speed in ml/min

its rate , pump speed in ml/min

3:04 pm

Vendor - TEL - Sameer Poyil

Fixed.

Fixed.

3:02 pm

Vendor - TEL - Sameer Poyil

When flag is true and Drain complete , it remains in the DRY_BICART_FLUID_DRAIN_END_STATE, when it is cleared, it go back to DRY_BICART_DRAIN_START_STATE Its fixed now

When flag is true and Drain complete , it remains in the DRY_BICART_FLUID_DRAIN_END_STATE, when it is cleared, it go back to DRY_BICART_DRAIN_START_STATE
Its fixed now

12:12 pm

Sean Nash

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.