BloodLeak.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I think you are seeing previous commit. It is not there in the present code.

I think you are seeing previous commit. It is not there in the present code.

Done. Thank you.

Done. Thank you.

Changed. Thank you.

Changed. Thank you.

is it merge issue ?

is it merge issue ?

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

Please bring public functions on top. check it for all function in this file , except test functions

Please bring public functions on top. check it for all function in this file , except test functions

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

LEAHI-DD-FIRMWARE-LDT-2030_Blood Leak - DD
LEAHI-DD-FIRMWARE-LDT-2030_Blood Leak - DD
structure packing missing

structure packing missing

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Removed. Thank you.

Removed. Thank you.

Moved the enums to driver header file. Fixed it.

Moved the enums to driver header file. Fixed it.

Fixed. Thank you.

Fixed. Thank you.

Fixed. Thank you.

Fixed. Thank you.

Removed. Thank you.

Removed. Thank you.

called it from here. Fixed it. Thank you

called it from here. Fixed it. Thank you

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thank you.

fixed. thanks

fixed. thanks

Remove extra blank line.

Remove extra blank line.

Keep 2 blank lines above/below test banner.

Keep 2 blank lines above/below test banner.

Packing only needed if it's used for transmission. I don't see this structure being broadcast anywhere.

Packing only needed if it's used for transmission. I don't see this structure being broadcast anywhere.