WatchdogMgmt.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use new generic confirmation approach.

Use new generic confirmation approach.

uiVersion is an input

uiVersion is an input

Should we update the comment as well to remove occlusion?

Should we update the comment as well to remove occlusion?

add a blank else block

add a blank else block

add comment

add comment

add a blank line above this comment.

add a blank line above this comment.

please add blank space between ( (int)postState ), TRUE );

please add blank space between ( (int)postState ), TRUE );

please add blank space between ( (int)postState ), TRUE );

please add blank space between ( (int)postState ), TRUE );

Alarm id should be 196? Description looks same as 194.

Alarm id should be 196?
Description looks same as 194.

Change PRES_OCCL to PRESSURE

Change PRES_OCCL to PRESSURE

Maybe move OperationModes.c?

Maybe move OperationModes.c?

Use generic confirmation functions/messages.

Use generic confirmation functions/messages.

Move this function to OperationModes.c.

Move this function to OperationModes.c.

From here forward, we can just call sendMessage() with appropriate params.

From here forward, we can just call sendMessage() with appropriate params.

Use generic helper function (sendMessage) in MessageSupport.c.

Use generic helper function (sendMessage) in MessageSupport.c.

Use generic confirmation functions/messages for off button.

Use generic confirmation functions/messages for off button.

Remove change.

Remove change.

LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6:
LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6:
So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

I think this enum should be in a different header file. I don't think this unit uses this enum.

I think this enum should be in a different header file. I don't think this unit uses this enum.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

Do these need to be public? I think only the driver should have to know sector addresses and sizes. If other units want to know these things, they should call a function in this driver to get them.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

I think isSectorStartAddress is a better function name.

I think isSectorStartAddress is a better function name.

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thoug...

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

don't forget to add function headers.

don't forget to add function headers.

// **************** private functions **************

// **************** private functions **************

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

Add a blank line before group end marker.

Add a blank line before group end marker.

No load cells in Leahi.

No load cells in Leahi.