td-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 8
Total Committers: 6
Last Commit: 19 Dec
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 19 Dec
1:57 pm

Dara Navaei

1:51 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AirPump.c
    • -1
    • +1
    ./AirTrap.c
    • -1
    • +1
    ./Ejector.c
    • -1
    • +1
    ./Ejector.h
    • -1
    • +1
    ./Valves.c
    • -1
    • +1
    ./Valves.h
  7. … 10 more files in changeset.
1:48 pm

Dara Navaei

Merge branch 'staging' into LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor

Options
    • -5
    • +5
    ./AirPump.c
    • -5
    • +5
    ./AirTrap.c
    • -4
    • +4
    ./Ejector.c
    • -4
    • +4
    ./Ejector.h
    • -5
    • +5
    ./Valves.c
    • -5
    • +5
    ./Valves.h
  7. … 10 more files in changeset.
12:16 pm

Vendor - TEL - Sameer Poyil and Sean Nash

Thursday 18 Dec
3:08 pm

Dara Navaei

We tend to initialize the local variables as a standard practice.

We tend to initialize the local variables as a standard practice.

3:01 pm

Dara Navaei

LDT-1886 updated the valves code to be able to rehome the valves if needed

Options
    • -2
    • +4
    ./Valves.c
  2. … 1 more file in changeset.
2:54 pm

Sean Nash

These don't need to be initialized to zero.

These don't need to be initialized to zero.

Wednesday 17 Dec
1:50 pm

Dara Navaei

LDT-1886 fixed the valves round down the encoder to division of 8 all the time

Options
    • -8
    • +2
    ./Valves.c
11:11 am

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -31
    • +31
    ./Ejector.c
    • -25
    • +25
    ./Valves.c
  3. … 1 more file in changeset.
11:07 am

Dara Navaei

Done

Done

11:06 am

Dara Navaei

Done

Done

11:05 am

Dara Navaei

Done

Done

11:04 am

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -37
    • +22
    ./Valves.c
10:49 am

Dara Navaei

Done

Done

10:48 am

Dara Navaei

Done

Done

Tuesday 16 Dec
2:55 pm

Dara Navaei

Done.

Done.

2:53 pm

Dara Navaei

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

2:17 pm

Sean Nash

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

2:15 pm

Sean Nash

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

2:13 pm

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.

2:13 pm

Sean Nash

Is this temporary?

Is this temporary?

2:12 pm

Sean Nash

2:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated.

Updated.

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, we need to

Yes, we need to

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:47 pm

Dara Navaei

LDT-1886 updated the valves homing sequence

Options
    • -70
    • +159
    ./Valves.c
    • -0
    • +1
    ./Valves.h
  3. … 4 more files in changeset.
1:44 pm

Sean Nash

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

1:43 pm

Sean Nash

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

1:36 pm

Sean Nash

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

1:32 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, I deleted.

Yes, I deleted.