DD-LEAH-230_FW DD Heaters Controller 1

Activity

DD-LEAH-230-1 28

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 25m 13 Done.
    Reviewer - Complete 1h 4m 15 Why 590? Magic number - use #define.
    Reviewer - Complete 0m    
    Reviewer - 0% reviewed 0m    
    jpaguio  (deleted user)
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   1h 31m 28  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/App/Controllers/DialysatePumps.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Heaters.c Changed 24
    Open in IDE #permalink
    /firmware/App/Controllers/Heaters.h Changed 2
    Open in IDE #permalink
    /firmware/App/Drivers/TemperatureSensors.c Changed 2
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.c Changed
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.h Changed
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed
    Open in IDE #permalink
    /firmware/App/DDCommon.h Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time