LEAHI-DD-FIRMWARE-LDT-3103

Remove blank line.

Remove blank line.

Add a blank line before return statement.

Add a blank line before return statement.

Why is this commented out?

Why is this commented out?

d48PumpSpeed is an input.

d48PumpSpeed is an input.

We will have to look at it as well. But for now, we are just monitoring the fresh side pressure variation.

We will have to look at it as well. But for now, we are just monitoring the fresh side pressure variation.

This is a testable value.

This is a testable value.

Should we remove the condition instead of commenting it out?

Should we remove the condition instead of commenting it out?

changed the name to differentiate between driver level and controller level functions.

changed the name to differentiate between driver level and controller level functions.

Yes. will tune them based on the test results.

Yes. will tune them based on the test results.

Fixed it.

Fixed it.

We handle it in the checkSpentFillComplete() mentioned in line 946.

We handle it in the checkSpentFillComplete() mentioned in line 946.

done.

done.

Why are we adjusting/reducing the speed of D48 by a factor of 50%?

Why are we adjusting/reducing the speed of D48 by a factor of 50%?

I thought we were going to complete cycle when done (not based on time) and feed back error in cycle time to control D48 pump speed to reduce error going forward so we end up getting the target cyc...

I thought we were going to complete cycle when done (not based on time) and feed back error in cycle time to control D48 pump speed to reduce error going forward so we end up getting the target cycle time which will give us target flow rate.

Where is the closed loop control?

Where is the closed loop control?

Is this an initial guess for pump control?

Is this an initial guess for pump control?

Add spaces before/after +=.

Add spaces before/after +=.

Shouldn't this kind of function be in the pump controller unit? Assuming such functions already exist in the controller, so why do we need these?

Shouldn't this kind of function be in the pump controller unit? Assuming such functions already exist in the controller, so why do we need these?

Why are we checking only fresh side pressures and not spent side as well?

Why are we checking only fresh side pressures and not spent side as well?

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -0
    • +14
    /sources/model/settings/MWifiNetwork.h
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -14
    • +0
    /sources/model/settings/MWifiNetwork.h
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -0
    • +14
    /sources/model/dg/data/MDGGeneralEvent.h
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 607 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated MAlarmMapping.cpp

    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Merged release/p1b/staging