LEAHI-DD-FIRMWARE-LDT-4733 LEAHI-DD-FIRMWARE-LDT-4733

Accordion

Stats

Commits this week: 0

Total Commits:	3,393
Last Commit:	18 Jun
Commits this week:	0

Commit Activity

Tuesday 14 Jul

2:58 pm

Michael Garthwaite

Thursday 09 Jul

3:40 pm

Vinayakam Mani and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-4733-1
finished reviewing

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

10:15 am

Michael Garthwaite

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733 Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733

Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

Wednesday 08 Jul

1:45 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4733-1
commented on review

Did you get a chance to test this alarm and uncomment the code?

Did you get a chance to test this alarm and uncomment the code?

1:44 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4733-1
commented on review

Remove empty space.

Remove empty space.

1:44 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4733-1
commented on review

ACToDC?

ACToDC?

1:42 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4733-1
commented on review

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

10:41 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4733-1
commented on review

Align comment. Clarify (at least in comments) that these macros are for FPGA count conversions.

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

10:38 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4733-1
commented on review

Remove extra blank lines.

Remove extra blank lines.

Thursday 25 Jun

8:47 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-4733-1
started review

LEAHI-DD-FIRMWARE-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data

LEAHI-DD-FIRMWARE-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data

Thursday 18 Jun

5:04 pm

Dara Navaei

More
be1982b
changed 1 file
staging in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -20
- +14
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

Thursday 11 Jun

11:11 am

Dara Navaei

More
04a8de8
changed 1 file
release/p1b/master in application

Bamboo Commit: Updated MAlarmMapping.cpp

- -14
- +20
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

10:59 am

Dara Navaei

More
15e2856
changed 1 file
release/p1b/master in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -20
- +14
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

10:33 am

Dara Navaei

More
26fd75a
changed 1 file
release/p1b/master in application

Merged release/p1b/staging and resolved the conflicts

- -2
- +2
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

9:28 am

Dara Navaei

More
b32b539
changed 1 file
release/p1b/master, release/p1b/staging in application

Bamboo Commit: Updated MAlarmMapping.cpp

- -14
- +20
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

9:15 am

Dara Navaei

More
bcb61e0
changed 8 files
release/p1b/master, release/p1b/staging in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/sources/canbus/MessageGlobals.h
- History
- Source
- Diff
/sources/canbus/MessageGlobals.h
- -1
- +1
/sources/canbus/MessageInterpreter.cpp
- History
- Source
- Diff
/sources/canbus/MessageInterpreter.cpp
- -1
- +1
/sources/gui/qml/pages/settings/SettingsInstitutionalRecord.qml
- History
- Source
- Diff
/sources/.../SettingsInstitutionalRecord.qml
- -1
- +1
/sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.cpp
- History
- Source
- Diff
/sources/.../MAdjustHDInstitutionalRecordResponse.cpp
- -1
- +1
/sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.h
- History
- Source
- Diff
/sources/.../MAdjustHDInstitutionalRecordResponse.h
- -20
- +14
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp
- -1
- +1
/sources/view/settings/VAdjustmentInstitutionalRecord.cpp
- History
- Source
- Diff
/sources/.../VAdjustmentInstitutionalRecord.cpp
- -1
- +1
/sources/view/settings/VAdjustmentInstitutionalRecord.h
- History
- Source
- Diff
/sources/.../VAdjustmentInstitutionalRecord.h

9:08 am

Dara Navaei

More
e2f04b1
changed 0 files
release/p1b/master, release/p1b/staging in application

Merged release/DENBUG-335-air-trap-fill-design-improvement-P1B-Staging

Tuesday 09 Jun

11:09 am

Dara Navaei

More
bfcb830
changed 9 files
release/DENBUG-335-air-trap-fill-design-improvement-P1B-Staging, release/p1b/master, release/p1b/staging in application UI-DENBUG-335-2

DENBUG-335: Air Trap Fill Design Improvements: Updated the institutional record to receive and display the end treatment blood flow rate in mL/min

- -12
- +12
/AlarmMapping.csv
- History
- Source
- Diff
/AlarmMapping.csv
- -1
- +1
/sources/canbus/MessageGlobals.h
- History
- Source
- Diff
/sources/canbus/MessageGlobals.h
- -1
- +1
/sources/canbus/MessageInterpreter.cpp
- History
- Source
- Diff
/sources/canbus/MessageInterpreter.cpp
- -1
- +1
/sources/gui/qml/pages/settings/SettingsInstitutionalRecord.qml
- History
- Source
- Diff
/sources/.../SettingsInstitutionalRecord.qml
- -0
- +4
/sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.cpp
- History
- Source
- Diff
/sources/.../MAdjustHDInstitutionalRecordResponse.cpp
- -0
- +3
/sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.h
- History
- Source
- Diff
/sources/.../MAdjustHDInstitutionalRecordResponse.h
- -2
- +2
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp
- -0
- +2
/sources/view/settings/VAdjustmentInstitutionalRecord.cpp
- History
- Source
- Diff
/sources/.../VAdjustmentInstitutionalRecord.cpp
- -0
- +3
/sources/view/settings/VAdjustmentInstitutionalRecord.h
- History
- Source
- Diff
/sources/.../VAdjustmentInstitutionalRecord.h

Friday 05 Jun

3:36 pm

Dara Navaei

More
d061ad6
changed 1 file
staging in application

Bamboo Commit: Updated MAlarmMapping.cpp

- -14
- +20
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

3:24 pm

Dara Navaei

More
607a5cf
changed 1 file
staging in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -20
- +14
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

Thursday 04 Jun

6:13 pm

Dara Navaei

More
6b9dcea
changed 1 file
staging in application

Bamboo Commit: Updated MAlarmMapping.cpp

- -15
- +21
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

6:07 pm

Dara Navaei

More
75d74f2
changed 8 files
staging in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/sources/canbus/MessageGlobals.h
- History
- Source
- Diff
/sources/canbus/MessageGlobals.h
- -1
- +1
/sources/canbus/MessageInterpreter.cpp
- History
- Source
- Diff
/sources/canbus/MessageInterpreter.cpp
- -1
- +1
/sources/gui/qml/pages/settings/SettingsInstitutionalRecord.qml
- History
- Source
- Diff
/sources/.../SettingsInstitutionalRecord.qml
- -1
- +1
/sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.cpp
- History
- Source
- Diff
/sources/.../MAdjustHDInstitutionalRecordResponse.cpp
- -1
- +1
/sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.h
- History
- Source
- Diff
/sources/.../MAdjustHDInstitutionalRecordResponse.h
- -20
- +14
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp
- -1
- +1
/sources/view/settings/VAdjustmentInstitutionalRecord.cpp
- History
- Source
- Diff
/sources/.../VAdjustmentInstitutionalRecord.cpp
- -1
- +1
/sources/view/settings/VAdjustmentInstitutionalRecord.h
- History
- Source
- Diff
/sources/.../VAdjustmentInstitutionalRecord.h

5:51 pm

Dara Navaei

More
50ba3b0
changed 0 files
staging in application

Merged DENBUG-335

Monday 01 Jun

10:43 am

Dara Navaei

More
cbb633d
changed 0 files
DENBUG-335-air-trap-fill-design-improvement, staging in application

Merge branch 'staging' into DENBUG-335-air-trap-fill-design-improvement

Friday 29 May

9:27 am

Dara Navaei

More
1b09e1e
changed 1 file
DENBUG-335-air-trap-fill-design-improvement, staging in application

Bamboo Commit: Updated MAlarmMapping.cpp

- -14
- +20
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

Atlassian Fisheye analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-08-11 23:41 -0700