LEAHI-TD-FIRMWARE-LDT-2240

LEAHI-TD-FIRMWARE-LDT-2240

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,393
Last Commit: 18 Jun
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 06 Jul
1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Tuesday 30 Jun
1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Friday 12 Jun
5:40 pm

Vinayakam Mani

Bubble status, Low and high level level sensors.

Bubble status, Low and high level level sensors.

5:39 pm

Vinayakam Mani

Input : Blood pump door status?

Input : Blood pump door status?

5:27 pm

Vinayakam Mani

To be restored?

To be restored?

5:24 pm

Vinayakam Mani

Are these being initialized in the init function?

Are these being initialized in the init function?

5:16 pm

Vinayakam Mani

Need to resolve the merge issues?

Need to resolve the merge issues?

Wednesday 03 Jun
9:51 am

Sean Nash

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD...

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

9:48 am

Sean Nash

Add doxygen comments to the right of each structure field.

Add doxygen comments to the right of each structure field.

9:47 am

Sean Nash

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

9:46 am

Sean Nash

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

9:44 am

Sean Nash

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

9:29 am

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

9:29 am

Sean Nash

Keep this blank line above group header.

Keep this blank line above group header.

9:28 am

Sean Nash

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Tuesday 19 May
5:39 pm

Sean Nash

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

Remove this blank line.

Remove this blank line.

Friday 15 May
9:52 am

Vendor - TEL - Varshini Nagabooshanam

I missed updating this earlier, I’ll push the updated code.

I missed updating this earlier, I’ll push the updated code.

9:19 am

Sean Nash

Can't have 3 values. Maximum 2 values allowed.

Can't have 3 values. Maximum 2 values allowed.

Wednesday 13 May
10:48 am

Vendor - TEL - Varshini Nagabooshanam

Removedd

Removedd

10:44 am

Vendor - TEL - Varshini Nagabooshanam

added

added

Tuesday 12 May
9:40 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Thursday 07 May
11:12 am

Sean Nash

Remove start state.

Remove start state.

10:30 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

updated

updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Yes, removed

Yes, removed

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

yes, removed

yes, removed