Vendor - TEL - Suresh Dharnala

About
  • This user has not yet committed.

Reviews

4 active reviews

Counts may include data that you cannot access.
Friday 07 Aug
1:27 pm

Vendor - TEL - Suresh Dharnala

Thursday 06 Aug
9:25 am

Vendor - TEL - Suresh Dharnala

9:21 am

Vendor - TEL - Suresh Dharnala

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the inte...

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

9:13 am

Vendor - TEL - Suresh Dharnala

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic plac...

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

Thursday 30 Jul
2:35 pm

Vendor - TEL - Suresh Dharnala

Yes, these are low-priority alarms

Yes, these are low-priority alarms

2:35 pm

Vendor - TEL - Suresh Dharnala

Yes, these are low-priority alarms

Yes, these are low-priority alarms

Wednesday 29 Jul
8:13 pm

Vendor - TEL - Suresh Dharnala

10:55 am

Vendor - TEL - Suresh Dharnala

Fixed.

Fixed.

10:54 am

Vendor - TEL - Suresh Dharnala

Moved.

Moved.

10:53 am

Vendor - TEL - Suresh Dharnala

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

Tuesday 28 Jul
12:57 pm

Vendor - TEL - Suresh Dharnala

Updated as suggested by removing the unnecessary else block and reject command. Retested the power-off confirmation and shutdown flow successfully.

Updated as suggested by removing the unnecessary else block and reject command. Retested the power-off confirmation and shutdown flow successfully.

12:56 pm

Vendor - TEL - Suresh Dharnala

Updated to remove the return from the middle of the function. The function now sets newID and returns only once at the end. Retested successfully.

Updated to remove the return from the middle of the function. The function now sets newID and returns only once at the end. Retested successfully.

Wednesday 22 Jul
9:28 pm

Vendor - TEL - Suresh Dharnala

I agree but it is already in the init function.

I agree but it is already in the init function.

Monday 20 Jul
1:39 pm

Vendor - TEL - Suresh Dharnala

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before en...

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.