Vendor - TEL - Sameer Poyil

About
  • First commit 20 November 2025
  • Latest commit 11 December 2025
Last Week All Time
Commits: 3 23

Reviews

14 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Vendor - TEL - Sameer Poyil is mapped to 4 committers over 3 repositories
Username ven.spoyil is mapped to:
Thursday 11 Dec
10:15 am

Vendor - TEL - Sameer Poyil

move static function after public function

move static function after public function

10:14 am

Vendor - TEL - Sameer Poyil

let public function on top

let public function on top

10:11 am

Vendor - TEL - Sameer Poyil

Let all public functions come on top for all files

Let all public functions come on top for all files

Wednesday 10 Dec
8:03 pm

Vendor - TEL - Sameer Poyil

is it merge issue ?

is it merge issue ?

7:56 pm

Vendor - TEL - Sameer Poyil

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

7:50 pm

Vendor - TEL - Sameer Poyil

Please bring public functions on top. check it for all function in this file , except test functions

Please bring public functions on top. check it for all function in this file , except test functions

Tuesday 09 Dec
11:20 am

Vendor - TEL - Sameer Poyil

11:12 am

Vendor - TEL - Sameer Poyil

comments should start with capital letter

comments should start with capital letter

Monday 08 Dec
7:02 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

7:00 pm

Vendor - TEL - Sameer Poyil

Let public function on top

Let public function on top

6:53 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

6:52 pm

Vendor - TEL - Sameer Poyil

Mixing static and public function , let public function comes on top

Mixing static and public function , let public function comes on top

6:50 pm

Vendor - TEL - Sameer Poyil

comment should start with capital letter

comment should start with capital letter

6:46 pm

Vendor - TEL - Sameer Poyil

comments should start with capital letter

comments should start with capital letter

Friday 05 Dec
8:52 am

Vendor - TEL - Sameer Poyil

structure packing missing

structure packing missing

8:48 am

Vendor - TEL - Sameer Poyil

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Wednesday 03 Dec
5:58 pm

Vendor - TEL - Sameer Poyil

Small letter used

Small letter used

6:29 am

Vendor - TEL - Sameer Poyil

add any override function if required

add any override function if required

6:28 am

Vendor - TEL - Sameer Poyil

publish filter flush status , add other important data , inlet pressure etc

publish filter flush status , add other important data , inlet pressure etc

6:23 am

Vendor - TEL - Sameer Poyil

do we need override function for high flow rate , low flow rate, conductivity, pressure etc ?

do we need override function for high flow rate , low flow rate, conductivity, pressure etc ?

6:20 am

Vendor - TEL - Sameer Poyil

arrange static and global function properly , public on top and static on bottom

arrange static and global function properly , public on top and static on bottom

6:19 am

Vendor - TEL - Sameer Poyil

Publish all other important data like conductivity and pressures

Publish all other important data like conductivity and pressures

Tuesday 02 Dec
11:43 pm

Vendor - TEL - Sameer Poyil

as a practice , we need to add a pragma pack for all structure irrespective of the size as per Sean.

as a practice , we need to add a pragma pack for all structure irrespective of the size as per Sean.

Monday 01 Dec
9:20 am

Vendor - TEL - Sameer Poyil

Structure packing statement missing. add it even if not required

Structure packing statement missing. add it even if not required

Wednesday 26 Nov
9:02 pm

Vendor - TEL - Sameer Poyil

Need to co-ordinate with drybicart message id since it is using 0x70

Need to co-ordinate with drybicart message id since it is using 0x70

7:10 pm

Vendor - TEL - Sameer Poyil

comment should start with Capital letter ?

comment should start with Capital letter ?

7:08 pm

Vendor - TEL - Sameer Poyil

I do not see structure packing. is it not required ?

I do not see structure packing. is it not required ?

7:07 pm

Vendor - TEL - Sameer Poyil

Not initialized ? who modifies this variable ?

Not initialized ? who modifies this variable ?

7:05 pm

Vendor - TEL - Sameer Poyil

not initialized in init function

not initialized in init function

Monday 24 Nov
1:29 pm

Vendor - TEL - Sameer Poyil

structure packing statement missing

structure packing statement missing