Zoltan Miskolci

2 hrs ago

Zoltan Miskolci

More
5bfe41c
changed 1 file
LDT-2787-fp_dd_proxy_commands in leahi-dialin LEAHI-DIALIN-LDT-2787-2

- Matching alarm publish name with variable name

- -1
- +1
/leahi_dialin/dd/modules/alarms.py
- History
- Source
- Diff
/leahi_dialin/dd/modules/alarms.py

3 hrs ago

Zoltan Miskolci

More
26b51fd
changed 2 files
LDT-2787-fp_dd_proxy_commands in leahi-dialin LEAHI-DIALIN-LDT-2787-2

- Updated test config names - Removed invalid publish from gen_dialysate

- -2
- +2
/leahi_dialin/common/test_config_defs.py
- History
- Source
- Diff
/leahi_dialin/common/test_config_defs.py
- -4
- +0
/leahi_dialin/dd/modules/gen_dialysate.py
- History
- Source
- Diff
/leahi_dialin/dd/modules/gen_dialysate.py

4 hrs ago

Zoltan Miskolci

More
LEAHI-DIALIN-LDT-2004-1
resumed reviewing

5 hrs ago

Zoltan Miskolci

More
LEAHI-DIALIN-LDT-3222-1
finished reviewing

5 hrs ago

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

5 hrs ago

Zoltan Miskolci

removed commented out line

5 hrs ago

Zoltan Miskolci

More
5476322
changed 1 file
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

removed

- -1
- +0
/leahi_dialin/td/modules/events.py
- History
- Source
- Diff
/leahi_dialin/td/modules/events.py

5 hrs ago

Zoltan Miskolci

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

5 hrs ago

Zoltan Miskolci

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

5 hrs ago

Zoltan Miskolci

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

5 hrs ago

Zoltan Miskolci

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

5 hrs ago

Zoltan Miskolci

Yes

5 hrs ago

Zoltan Miskolci

Based on the msg id, it should be here

5 hrs ago

Zoltan Miskolci

More
90f9b43
changed 3 files
LDT-2994-iofp-valve-data-is-inaccurate in leahi-dialin

- fixed valve_state_enums to be updated - Fixed balancing chamber broadcast processing

- -1
- +1
/leahi_dialin/dd/modules/balancing_chamber.py
- History
- Source
- Diff
/leahi_dialin/dd/.../balancing_chamber.py
- -2
- +6
/leahi_dialin/dd/modules/valves.py
- History
- Source
- Diff
/leahi_dialin/dd/modules/valves.py
- -3
- +6
/leahi_dialin/fp/modules/valves.py
- History
- Source
- Diff
/leahi_dialin/fp/modules/valves.py

10 hrs ago

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-2004-1
commented on review

Please pull the latest staging and update the test configs regarding that. I think the dry bicart test config is already there

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

3:33 pm

Zoltan Miskolci

More
9bfb4b4
changed 2 files
LDT-2787-fp_dd_proxy_commands in leahi-dialin LEAHI-DIALIN-LDT-2787-2

Merge branch 'staging' into LDT-2787-fp_dd_proxy_commands

- -109
- +113
/leahi_dialin/fp/filtration_purification.py
- History
- Source
- Diff
/leahi_dialin/.../filtration_purification.py
- -8
- +9
/leahi_dialin/fp/proxies/dd_proxy.py
- History
- Source
- Diff
/leahi_dialin/fp/proxies/dd_proxy.py

2:42 pm

Zoltan Miskolci

More
95a7bdc
changed 3 files
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

- added new option to from_str - Fixed dd valve ids - Added a new str to pregen option

- -1
- +1
/leahi_dialin/common/fp_defs.py
- History
- Source
- Diff
/leahi_dialin/common/fp_defs.py
- -2
- +2
/leahi_dialin/dd/modules/valves.py
- History
- Source
- Diff
/leahi_dialin/dd/modules/valves.py
- -0
- +3
/leahi_dialin/utils/base.py
- History
- Source
- Diff
/leahi_dialin/utils/base.py

10:51 am

Zoltan Miskolci

More
963c103
changed 1 file
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

fixed renaming

- -1
- +1
/leahi_dialin/common/dd_defs.py
- History
- Source
- Diff
/leahi_dialin/common/dd_defs.py

10:50 am

Zoltan Miskolci

More
5a17813
changed 1 file
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

- fixed event, removed TPAR Op mode

- -1
- +1
/leahi_dialin/td/modules/events.py
- History
- Source
- Diff
/leahi_dialin/td/modules/events.py

5:00 pm

Zoltan Miskolci

More
ac11d0b
changed 1 file
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

removed from string conversion too

- -1
- +0
/leahi_dialin/common/td_defs.py
- History
- Source
- Diff
/leahi_dialin/common/td_defs.py

4:55 pm

Zoltan Miskolci

Removed

4:54 pm

Zoltan Miskolci

More
9525ca4
changed 1 file
LDT-3350-add_from_str in leahi-dialin

removed tMODE_TPAR from TDOpModes

- -6
- +5
/leahi_dialin/common/td_defs.py
- History
- Source
- Diff
/leahi_dialin/common/td_defs.py

1:24 pm

Zoltan Miskolci

More
79d11a9
changed 2 files
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

Added from_str to td_def enums

- -3
- +3
/leahi_dialin/common/__init__.py
- History
- Source
- Diff
/leahi_dialin/common/__init__.py
- -242
- +319
/leahi_dialin/common/td_defs.py
- History
- Source
- Diff
/leahi_dialin/common/td_defs.py

11:30 am

Zoltan Miskolci

More
LEAHI-DIALIN-LDT-2749-1
finished reviewing

10:46 am

Zoltan Miskolci

More
e0f60f0
changed 1 file
LDT-3350-add_from_str in leahi-dialin

convert half of td_defs

- -446
- +470
/leahi_dialin/common/td_defs.py
- History
- Source
- Diff
/leahi_dialin/common/td_defs.py

5:08 pm

Zoltan Miskolci

More
5c4a3b4
changed 4 files
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

- Updated dd_Defs to use static enums - Switched auto to integers for easier identification during debug - Changed name generation in build script to remove errors from python about name

- -5
- +10
/build.sh
- History
- Source
- Diff
/build.sh
- -740
- +851
/leahi_dialin/common/dd_defs.py
- History
- Source
- Diff
/leahi_dialin/common/dd_defs.py
- -72
- +0
/leahi_dialin/common/defs_base.py
- History
- Source
- Diff
/leahi_dialin/common/defs_base.py
- -134
- +134
/leahi_dialin/common/fp_defs.py
- History
- Source
- Diff
/leahi_dialin/common/fp_defs.py

2:08 pm

Zoltan Miskolci

More
defe599
changed 2 files
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

fp_defs conversion to static enums

- -484
- +510
/leahi_dialin/common/fp_defs.py
- History
- Source
- Diff
/leahi_dialin/common/fp_defs.py
- -0
- +25
/leahi_dialin/utils/base.py
- History
- Source
- Diff
/leahi_dialin/utils/base.py

9:43 am

Zoltan Miskolci

More
3a2a21d
changed 4 files
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

added from_str to td_defs

- -2
- +2
/leahi_dialin/common/dd_defs.py
- History
- Source
- Diff
/leahi_dialin/common/dd_defs.py
- -0
- +3
/leahi_dialin/common/defs_base.py
- History
- Source
- Diff
/leahi_dialin/common/defs_base.py
- -2
- +2
/leahi_dialin/common/fp_defs.py
- History
- Source
- Diff
/leahi_dialin/common/fp_defs.py
- -285
- +410
/leahi_dialin/common/td_defs.py
- History
- Source
- Diff
/leahi_dialin/common/td_defs.py

5:42 pm

Zoltan Miskolci

More
3fe3a53
changed 1 file
LDT-3350-add_from_str in leahi-dialin

from_str added to dd_def enums

- -377
- +459
/leahi_dialin/common/dd_defs.py
- History
- Source
- Diff
/leahi_dialin/common/dd_defs.py

4:53 pm

Zoltan Miskolci

More
9722173
changed 2 files
LDT-3350-add_from_str in leahi-dialin LEAHI-DIALIN-LDT-3350-1

Added from_str to fp_def enums

- -0
- +69
/leahi_dialin/common/defs_base.py
- History
- Source
/leahi_dialin/common/defs_base.py
- -213
- +262
/leahi_dialin/common/fp_defs.py
- History
- Source
- Diff
/leahi_dialin/common/fp_defs.py

Zoltan Miskolci

About

eval(decodeURIComponent('%64%6F%63%75%6D%65%6E%74%2E%77%72%69%74%65%28%22%7A%6D%69%73%6B%6F%6C%63%69%40%64%69%61%6C%69%74%79%2E%63%6F%6D%22%29')); var scriptElem = document.getElementById('to-removed') scriptElem.parentNode.removeChild(scriptElem);

Reviews

22 active reviews

Line History

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Committer Mappings

Zoltan Miskolci is mapped to 3 committers over 2 repositories