Activity leahi-dialin/

3 hrs ago

Sean Nash and Zoltan Miskolci

More
LEAHI-DIALIN-LDT-3222-1
finished reviewing

3 hrs ago

Behrouz NematiPour

Look in the td_defs.py for the same comment.

3 hrs ago

Behrouz NematiPour

Look in the td_defs.py for the same comment.

3 hrs ago

Behrouz NematiPour

Look in the td_defs.py for the same comment.

3 hrs ago

Behrouz NematiPour

Look in the td_defs.py for the same comment.

3 hrs ago

Behrouz NematiPour

This design is incorrect, For common codes, a proxy or a wrapper class should have been implemented. We will keep it for now to unblock the rest of the team.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

3 hrs ago

This is incorrect. We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use. We will keep it for now to unblock the rest of the...

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

4 hrs ago

Vendor - TEL - Sameer Poyil , Zoltan Miskolci and Michael Garthwaite

More
LEAHI-DIALIN-LDT-2004-1
finished reviewing

5 hrs ago

Zoltan Miskolci

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

5 hrs ago

Zoltan Miskolci

removed commented out line

5 hrs ago

Dara Navaei

More
LEAHI-DIALIN-LDT-3222-1
started review

LEAHI-DIALIN-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides

5 hrs ago

Zoltan Miskolci

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

5 hrs ago

Zoltan Miskolci

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

5 hrs ago

Zoltan Miskolci

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

5 hrs ago