application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 08 Jan 2021
6:51 pm

Behrouz NematiPour

DEN-5837: Code Analysis

Options
    • -5
    • +7
    /cppcheck.err
    • -94
    • +104
    /cppcheck.log
    • -0
    • +3
    /cr_objectives.sh
    • -1
    • +1
    /denali.pro.user
6:46 pm

Behrouz NematiPour

UI-DEN-5830_Alarm Design
UI-DEN-5830_Alarm Design
6:32 pm

plucia  (deleted user)

UI-DEN-6349_BP HR Manual Entry
UI-DEN-6349_BP HR Manual Entry
6:32 pm

plucia  (deleted user)

On 1.8.2021: Code Coverage: 100% SquishQt Tests: 100% passing

On 1.8.2021:
Code Coverage: 100%
SquishQt Tests: 100% passing

6:32 pm

plucia  (deleted user)

Reviewers please note: According to the qt virtual keyboard technical styling guide, here it is recommended to use Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default as a base fo...

Reviewers please note:

According to the qt virtual keyboard technical styling guide, here
it is recommended to use 

 Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default

as a base for the custom style. The Qt virtual keyboard styling files (called default and retro) I could find are located here on our VM: 

 /opt/Qt5.12.5/5.12.5/Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default


You'll notice that the Qt company has only provided the button images in the svg format. It appears they did this to allow for greater customization of the keyboard styling in the qml code.

I'm aware it has been decided to use pngs in the denali application. If requested, I can change the default Qt-provided keyboard style.qml file to use pngs instead of svgs.
It would be helpful before I do so to get feedback on the look and feel of the numeric keyboard so we have an agreed-upon style, size, and layout of the numeric keyboard, as converting the svgs to pngs will hard-code the styling.

3:37 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- 100.000% (4827/4827)

- added a unit test for the AlarmGenerator private method setBits.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -3
    • +9
    /sources/AlarmGenerator.h
    • -0
    • +17
    /unittests/tst_messaging.cpp
    • -0
    • +2
    /unittests/tst_messaging.h
1:35 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- 99.979% (4826/4827)

Options
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -2
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -40
    • +41
    /sources/canbus/MessageInterpreter.cpp
    • -5
    • +16
    /sources/model/MModel.h
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
1:16 pm

Peter Lucia <plucia@diality.com>

DEN-6349: Updated Keyboard style and positioning

Options
    • -1
    • +1
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -0
    • +2
    /sources/gui/qml/globals/Colors.qml
    • -0
    • +1
    /sources/gui/qml/globals/Variables.qml
    • -7
    • +7
    /sources/gui/qml/keyboard/style.qml
11:16 am

Peter Lucia <plucia@diality.com>

DEN-6352: Numeric keyboard styling adjustments

Options
    • -2
    • +2
    /denali.pro.user
    • -9
    • +16
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -3
    • +3
    /sources/gui/qml/globals/Variables.qml
    • -13
    • +10
    /sources/gui/qml/keyboard/style.qml
11:08 am

Peter Lucia <plucia@diality.com>

DEN-6352: Added Qt virtualkeyboard

Options
    • -0
    • +16
    /denali.qrc
    • -0
    • +1
    /main.cpp
    • -4
    • +6
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -0
    • +23
    /sources/gui/qml/keyboard/images/backspace-868482.svg
    • -0
    • +8
    /sources/gui/qml/keyboard/images/check-868482.svg
    • -0
    • +13
    /sources/gui/qml/keyboard/images/enter-868482.svg
    • -0
    • +28
    /sources/gui/qml/keyboard/images/globe-868482.svg
    • -0
    • +18
    /sources/gui/qml/keyboard/images/handwriting-868482.svg
    • -0
    • +55
    /sources/gui/qml/keyboard/images/hidekeyboard-868482.svg
    • -0
    • +14
    /sources/gui/qml/keyboard/images/search-868482.svg
    • -0
    • +201
    /sources/gui/qml/keyboard/images/selectionhandle-bottom.svg
    • -0
    • +12
    /sources/gui/qml/keyboard/images/shift-80c342.svg
    • -0
    • +12
    /sources/gui/qml/keyboard/images/shift-868482.svg
    • -0
    • +12
    /sources/gui/qml/keyboard/images/shift-c5d6b6.svg
    • -0
    • +33
    /sources/gui/qml/keyboard/images/textmode-868482.svg
    • -0
    • +1036
    /sources/gui/qml/keyboard/style.qml
Thursday 07 Jan 2021
5:13 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- commented as manually tested the AlarmClearedCondition.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +2
    /sources/AlarmGenerator.cpp
    • -1
    • +2
    /sources/canbus/MessageInterpreter.cpp
    • -3
    • +3
    /sources/gui/GuiController.cpp
    • -1
    • +0
    /sources/gui/qml/components/TimeText.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -2
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
4:45 pm

Peter Lucia <plucia@diality.com>

DEN-6352, DEN-6353: Displaying the numeric keyboard under text input fields.

Options
    • -0
    • +2
    /main.cpp
    • -2
    • +1
    /sources/gui/qml/components/FieldInput.qml
    • -0
    • +13
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -0
    • +1
    /sources/gui/qml/globals/Variables.qml
10:47 am

Peter Lucia <plucia@diality.com>

DEN-6353, DEN-6354: Added vitals manual entry page.

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /denali.qrc
    • -0
    • +51
    /sources/gui/qml/components/FieldInput.qml
    • -0
    • +121
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -0
    • +6
    /sources/gui/qml/globals/Variables.qml
    • -0
    • +1
    /sources/gui/qml/main.qml
    • -1
    • +7
    /sources/view/VBluetooth.cpp
    • -1
    • +6
    /sources/view/VVitals.cpp
    • -0
    • +1
    /sources/view/VVitals.h
Tuesday 05 Jan 2021
6:55 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:54 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

6:51 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -2
    • +3
    /denali.pro
6:05 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -2
    • +1
    /denali.pro
    • -6
    • +6
    /denali.pro.user
    • -4
    • +3
    /sources/gui/qml/main.qml
    • -16
    • +16
    /sources/gui/qml/pages/ManagerHome.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -60
    • +0
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.cpp
    • -0
    • +60
    /sources/view/hd/adjustment/VTreatmentAdjustmentVersions.cpp
    • -3
    • +6
    /sources/view/hd/adjustment/VTreatmentAdjustmentVersions.h
5:20 pm

Behrouz NematiPour

DEN-5836: Alarm:Code Coverage

- 99.110% (4790/4833)

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -0
    • +2
    /sources/model/hd/alarm/MAlarmClearedCondition.cpp
    • -1
    • +2
    /sources/model/hd/alarm/MAlarmClearedCondition.h
    • -1
    • +1
    /sources/view/hd/alarm/VAlarmStatus.cpp
5:16 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -6
    • +4
    /denali.pro
    • -2
    • +1
    /sources/gui/guiglobals.cpp
    • -8
    • +8
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.h
    • -41
    • +0
    /sources/view/dg/adjustment/VTreatmentAdjustmentDGVersions.cpp
    • -68
    • +0
    /sources/view/dg/adjustment/VTreatmentAdjustmentDGVersions.h
    • -13
    • +32
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.cpp
    • -68
    • +0
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.h
    • -0
    • +78
    /sources/view/hd/adjustment/VTreatmentAdjustmentVersions.h
    • -2
    • +1
    /sources/view/vview.h
11:21 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:57 am

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -3
    • +3
    /sources/model/dg/data/MDGAccelerometerData.h
10:57 am

pmontazemi  (deleted user)

Addressed.

Addressed.

Monday 04 Jan 2021
2:43 pm

Behrouz NematiPour

DEN-5836: Alarm:Code Coverage

- updated the alarm message table

- fixed the -q parameter

Options
    • -1
    • +1
    /denali.pro.user
    • -59
    • +111
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -9
    • +8
    /sources/view/hd/alarm/VAlarmStatus.cpp
Sunday 03 Jan 2021
10:48 pm

Behrouz NematiPour

incorrect comment line has been changed. please revert back "Datum" and change the infoText section.

incorrect comment line has been changed.
please revert back "Datum" and change the infoText section.

10:40 pm

Behrouz NematiPour

RESOLVED

RESOLVED

10:37 pm

Behrouz NematiPour

RESOLVED

RESOLVED

10:34 pm

Behrouz NematiPour

RESOLVED

RESOLVED

10:31 pm

Behrouz NematiPour

RESOLVED

RESOLVED

10:30 pm

Behrouz NematiPour

RESOLVED

RESOLVED

10:25 pm

Behrouz NematiPour

RESOLVED

RESOLVED