application

Clone Tools

Stats

Commits this week: 2
Total Committers: 14
Last Commit: 11:51
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 Jan 2021
10:57 am

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -2
    • +2
    /cppcheck.err
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /denali.qrc
    • -76
    • +0
    /sources/gui/qml/components/DenaliTextInput.qml
    • -1
    • +6
    /sources/gui/qml/components/Keyboard.qml
    • -0
    • +76
    /sources/gui/qml/components/TextEntry.qml
    • -28
    • +26
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -2
    • +7
    /sources/gui/qml/globals/Variables.qml
    • -4
    • +7
    /sources/gui/qml/main.qml
    • -1
    • +1
    /sources/view/VBluetooth.cpp
    • -28
    • +30
    /sources/view/VVitals.cpp
    • -21
    • +17
    /sources/view/VVitals.h
Tuesday 12 Jan 2021
6:59 pm

Behrouz NematiPour

same

same

6:59 pm

Behrouz NematiPour

same

same

6:58 pm

Behrouz NematiPour

same

same

6:58 pm

Behrouz NematiPour

same

same

6:58 pm

Behrouz NematiPour

the coverage is done without these object names on the Alarm design branch please remove them.

the coverage is done without these object names on the Alarm design branch please remove them.

6:53 pm

Behrouz NematiPour

Please Simply use the iArrow. why rotating two line to shape an arrow ?!

Please Simply use the iArrow. why rotating two line to shape an arrow ?!

6:40 pm

Behrouz NematiPour

This component is so general and not all the use cases need a back button. Please remove it from here and move it somewhere more suitable.

This component is so general and not all the use cases need a back button.
Please remove it from here and move it somewhere more suitable.

6:34 pm

Behrouz NematiPour

QObject has a built-in time. override the : void <class>::timerEvent(QTimerEvent *) \sa MainTimer

QObject has a built-in time.
override the :
void <class>::timerEvent(QTimerEvent *)
\sa MainTimer

6:31 pm

Behrouz NematiPour

DEN-5754: Implementation

- Removed not used SliderDoubleCreateTreatment.qml component.

Options
    • -1
    • +0
    /denali.qrc
    • -194
    • +0
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
6:08 pm

Behrouz NematiPour

Please remove if not used.

Please remove if not used.

5:58 pm

Behrouz NematiPour

removed.

removed.

5:58 pm

Behrouz NematiPour

Thanks for catching that. Fixed. This script is helping to have a summary of the objectives in the code reviews and a summary of what has been done in this branch.

Thanks for catching that. Fixed.
This script is helping to have a summary of the objectives in the code reviews and a summary of what has been done in this branch.

5:56 pm

Behrouz NematiPour

deleted

deleted

5:56 pm

Behrouz NematiPour

DEN-5838: Code Review 0

Options
    • -1
    • +2
    /cr_objectives.sh
    • -1
    • +0
    /sources/model/hd/alarm/MAlarmStatusData.cpp
5:44 pm

Behrouz NematiPour

DEN-5754: Implementation

- code refactoring and clean up

Options
    • -1
    • +1
    /denali.pro.user
    • -5
    • +8
    /denali.qrc
    • -0
    • +55
    /sources/gui/qml/components/TitleBarCreateTreatment.qml
    • -55
    • +0
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -0
    • +55
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentBase.qml
    • -0
    • +88
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentConfirm.qml
    • -0
    • +660
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -0
    • +124
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentPrime.qml
    • -0
    • +123
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentUltrafiltration.qml
    • -144
    • +0
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -108
    • +0
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -670
    • +0
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -140
    • +0
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -11
    • +12
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
5:44 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:44 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:39 pm

plucia  (deleted user)

Was this added by mistake?

Was this added by mistake?

5:36 pm

plucia  (deleted user)

Can delete

Can delete

5:33 pm

plucia  (deleted user)

Can delete

Can delete

5:33 pm

plucia  (deleted user)

Why were the extra sleeps needed? I don't have them and it's working fine

Why were the extra sleeps needed? I don't have them and it's working fine

4:37 pm

Behrouz NematiPour

I only wanted to exclude them from coco, but for some, I had to completely comment them, but still kept the ones that don't require to be commented.

I only wanted to exclude them from coco, but for some, I had to completely comment them, but still kept the ones that don't require to be commented.

4:34 pm

Behrouz NematiPour

Kept it as a place holder to keep all 16 bits visibly used.

Kept it as a place holder to keep all 16 bits visibly used.

4:33 pm

Behrouz NematiPour

there were useless tests where the QVerify and QCompare were removed from them after using the template function notify.

there were useless tests where the QVerify and QCompare were removed from them after using the template function notify.

4:24 pm

Behrouz NematiPour

It still applied to the newly created file. I would prefer to have something more general like: *TextEntry And please don't use a name like "Denali" which is subject to change.

It still applied to the newly created file.
I would prefer to have something more general like:

  • TextEntry
    And please don't use a name like "Denali" which is subject to change.
4:22 pm

plucia  (deleted user)

Can delete

Can delete

4:21 pm

Behrouz NematiPour

It still applied to the newly created file.

It still applied to the newly created file.

4:21 pm

plucia  (deleted user)

Application is spelled wrong What is this for?

Application is spelled wrong
What is this for?

4:21 pm

Behrouz NematiPour

please put the even verb at the end. pressedEnter => enterPressed eg. clickedBack => backClicked clickedContinue => continueClicked **"please follow this everywhere in the code."**

please put the even verb at the end.
pressedEnter => enterPressed
eg.
clickedBack => backClicked
clickedContinue => continueClicked

**"please follow this everywhere in the code."**