application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Nov 2020
3:39 pm

Behrouz NematiPour

DEN-4698: Code Review 0

- Found a bug during demo preparation:

The main treatment pressure section should only get updated if the request updated and should not be bound to the properties.

Options
    • -7
    • +24
    /sources/gui/qml/pages/treatment/TreatmentStart.qml
    • -0
    • +14
    /sources/gui/qml/pages/treatment/sections/TreatmentPressures.qml
2:25 pm

Behrouz NematiPour

DEN-4698: Code Review 0

Options
    • -1
    • +0
    /sources/canbus/MessageInterpreter.cpp
2:12 pm

Behrouz NematiPour

DEN-4698: Code Review 0

- Found a bug during preparation for the demo

when the ranges were adjusted by user then the ranges came back from FW were not updating the sliders handlers.

Options
    • -0
    • +7
    /sources/gui/qml/compounds/PressureRangeSlider.qml
9:28 am

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review comments

Options
    • -10
    • +0
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -0
    • +1
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
Monday 09 Nov 2020
7:56 pm

Behrouz NematiPour

DEN-4693: Update Design Documents

- Updated the messages MSG to hex for SDD.

Options
    • -1
    • +1
    /denali.pro.user
    • -3
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustPressuresLimitsResponse.h
    • -6
    • +6
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -3
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustSalineResponse.h
    • -3
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.h
5:00 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Added HD Versions implementation without *.qml needed changes.

Options
    • -2
    • +2
    /sources/canbus/messagedispatcher.cpp
    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
    • -11
    • +10
    /sources/model/MModel.h
    • -1
    • +1
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.cpp
    • -1
    • +1
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.h
    • -1
    • +1
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -2
    • +2
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.cpp
    • -2
    • +2
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.h
12:03 am

Behrouz NematiPour

DEN-4697: Static Code Analysis

Options
    • -13
    • +13
    /cppcheck.err
    • -84
    • +93
    /cppcheck.log
    • -1
    • +0
    /main.cpp
    • -1
    • +0
    /sources/view/hd/adjustment/VTreatmentAdjustmentPressuresLimits.cpp
Friday 06 Nov 2020
6:02 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Added HD Versions implementation without *.qml needed changes.

Options
    • -1
    • +0
    /denali.pro
    • -64
    • +0
    /sources/model/hd/data/MHDVersionData.cpp
5:54 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Added HD Versions implementation without *.qml needed changes.

Options
    • -0
    • +1
    /sources/canbus/messagedispatcher.cpp
    • -1
    • +1
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.cpp
5:50 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Added HD Versions implementation without *.qml needed changes.

Options
    • -1
    • +0
    /sources/canbus/messagedispatcher.cpp
    • -1
    • +1
    /sources/view/vview.h
5:44 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Added HD Versions implementation without *.qml needed changes.

Options
    • -2
    • +2
    /sources/model/MModel.h
    • -5
    • +0
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.cpp
5:31 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Added HD Versions implementation without *.qml needed changes.

Options
    • -2
    • +1
    /denali.pro
    • -2
    • +2
    /sources/canbus/messagedispatcher.cpp
    • -1
    • +1
    /sources/canbus/messagedispatcher.h
    • -3
    • +1
    /sources/canbus/messageglobals.h
    • -5
    • +5
    /sources/canbus/messageinterpreter.cpp
    • -1
    • +1
    /sources/gui/guiglobals.cpp
    • -2
    • +1
    /sources/gui/guiglobals.h
    • -15
    • +15
    /sources/model/MModel.h
    • -65
    • +0
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionResponse.cpp
    • -0
    • +65
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.cpp
    • -1
    • +1
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.h
    • -2
    • +2
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -2
    • +2
    /sources/view/hd/adjustment/VTreatmentAdjustmentHDVersions.h
    • -31
    • +0
    /sources/view/hd/data/VHDVersionData.cpp
4:37 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Added HD Versions implementation without *.qml needed changes.

Options
    • -4
    • +4
    /denali.pro
    • -45
    • +0
    /sources/model/hd/adjustment/MHDVersionResponse.cpp
    • -0
    • +65
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionResponse.cpp
4:23 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Added HD Versions implementation without *.qml needed changes.

Options
    • -1
    • +6
    /denali.pro
    • -1
    • +1
    /main.cpp
    • -3
    • +2
    /sources/applicationpost.h
    • -0
    • +12
    /sources/canbus/messagedispatcher.cpp
    • -4
    • +3
    /sources/canbus/messagedispatcher.h
    • -2
    • +6
    /sources/canbus/messageglobals.h
    • -0
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -4
    • +2
    /sources/canbus/messageinterpreter.h
    • -2
    • +3
    /sources/gui/guiglobals.cpp
    • -4
    • +7
    /sources/gui/guiglobals.h
    • -1
    • +0
    /sources/main.h
    • -17
    • +27
    /sources/model/MModel.h
    • -0
    • +45
    /sources/model/hd/adjustment/MHDVersionResponse.cpp
    • -0
    • +71
    /sources/model/hd/adjustment/MTreatmentAdjustHDVersionsResponse.h
    • -4
    • +16
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
  16. … 7 more files in changeset.
2:35 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Fixed bicarbonate concentrate enum

Options
    • -3
    • +1
    /sources/view/VTreatmentCreate.h
    • -2
    • +2
    /unittests/tst_views.cpp
Thursday 05 Nov 2020
3:13 pm

Behrouz NematiPour

DEN-4696: Code Coverage [99.722]

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /en_US.udic
    • -0
    • +2
    /sources/storage/Logger.cpp
    • -1
    • +4
    /sources/view/hd/adjustment/VTreatmentAdjustmentPressuresLimits.h
    • -0
    • +9
    /unittests/tst_messaging.cpp
    • -0
    • +1
    /unittests/tst_messaging.h
    • -0
    • +63
    /unittests/tst_models.cpp
    • -0
    • +4
    /unittests/tst_models.h
Wednesday 04 Nov 2020
11:02 am

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review requests.

Options
    • -2
    • +2
    /sources/gui/qml/components/Slider.qml
    • -3
    • +2
    /sources/storage/StorageGlobals.cpp
    • -2
    • +2
    /sources/storage/StorageGlobals.h
    • -1
    • +1
    /sources/view/VTreatmentCreate.h
10:32 am

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review requests.

Options
    • -1
    • +1
    /sources/canbus/MessageInterpreter.h
    • -1
    • +1
    /sources/gui/qml/components/Slider.qml
    • -1
    • +1
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -2
    • +2
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
    • -1
    • +1
    /sources/model/MEndTreatmentResponse.h
    • -20
    • +20
    /sources/model/MTreatmentParametersResp.h
    • -1
    • +25
    /sources/model/hd/data/MPrimingData.h
    • -46
    • +0
    /unittests/tst_canbus.cpp
    • -6
    • +0
    /unittests/tst_canbus.h
    • -0
    • +50
    /unittests/tst_models.cpp
    • -0
    • +7
    /unittests/tst_models.h
Tuesday 03 Nov 2020
11:04 pm

Behrouz NematiPour

DEN-5034: Implementation [ Messaging ] (2 of 2)

- Added adjustment Request Response in the UI

- Added Logging console out which is more descriptive only for debugging.

- Added multiple different min/max limit/ranges for pressures adjustments.

- Added auto calculate the adjustable low/high limit margin.

- Added a CONSTANT property #define

Options
    • -4
    • +4
    /denali.pro.user
    • -17
    • +35
    /main.cpp
    • -0
    • +31
    /sources/gui/qml/globals/Variables.qml
    • -6
    • +19
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -4
    • +4
    /sources/gui/qml/pages/treatment/TreatmentStart.qml
    • -38
    • +6
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
    • -0
    • +16
    /sources/main.h
    • -25
    • +11
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -5
    • +18
    /sources/storage/Logger.cpp
    • -2
    • +7
    /sources/storage/Logger.h
    • -0
    • +2
    /sources/view/hd/adjustment/VTreatmentAdjustmentPressuresLimits.cpp
    • -13
    • +12
    /sources/view/hd/adjustment/VTreatmentAdjustmentPressuresLimits.h
6:09 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Added class documentation and messaging information.

Options
    • -0
    • +22
    /sources/model/MEndTreatmentResponse.h
    • -0
    • +23
    /sources/model/MStartTreatmentResponse.h
    • -1
    • +41
    /sources/model/MTreatmentParametersResp.h
    • -10
    • +91
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +7
    /sources/view/VPriming.h
    • -0
    • +5
    /sources/view/VTreatmentBegin.h
    • -2
    • +7
    /sources/view/VTreatmentCreate.h
    • -0
    • +8
    /sources/view/VTreatmentEnd.h
4:23 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Removed newline characters. Fixed orgnization in denali.pro

Options
    • -13
    • +13
    /denali.pro
    • -3
    • +3
    /denali.pro.user
    • -3
    • +0
    /sources/model/MEndTreatmentResponse.h
    • -2
    • +0
    /sources/model/MStartTreatmentResponse.h
    • -2
    • +0
    /sources/model/hd/data/MPrimingData.h
    • -4
    • +0
    /sources/view/hd/alarm/VAlarmStatus.h
2:39 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Created constants for treatment parameter default, min, max, and resolution values. Included PRS references.

Options
    • -20
    • +136
    /sources/view/VTreatmentCreate.h
Monday 02 Nov 2020
10:05 pm

Behrouz NematiPour

DEN-5033: Implementation [ Messaging ] (1 of 2)

- improving and testing the Arterial/Venous pressure values

- using the doAdjustment of the venousPressureMinimum : vTreatmentAdjustmentPressuresLimits.venousLimitMin

in the QML.

Options
    • -2
    • +2
    /denali.pro.user
    • -0
    • +1
    /en_US.udic
    • -0
    • +2
    /sources/gui/qml/globals/Variables.qml
    • -12
    • +26
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -10
    • +12
    /sources/gui/qml/pages/treatment/TreatmentStart.qml
    • -12
    • +0
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
    • -6
    • +5
    /sources/gui/qml/pages/treatment/sections/TreatmentPressures.qml
    • -8
    • +30
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -5
    • +14
    /sources/view/hd/adjustment/VTreatmentAdjustmentPressuresLimits.h
    • -0
    • +1
    /sources/view/hd/data/VTreatmentPressureOcclusion.h
5:05 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Reverting adding a left and right touch margin

- While the addition of these margins makes it easier to hit the knob, it also adds a distance during drag between the click point and the displayed knob position. If still needed, there should be a better way of increasing the left and right touch margin.

Options
    • -2
    • +0
    /sources/gui/qml/components/RangeRect.qml
4:13 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Updated ConfirmTreatmentTableEntry's description

Options
    • -0
    • +1
    /sources/gui/qml/components/ConfirmTreatmentTableEntry.qml
4:01 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Moved ConfirmTreatmentTableEntry.qml to the right place.

Options
    • -66
    • +0
    /ConfirmTreatmentTableEntry.qml
    • -1
    • +1
    /denali.qrc
    • -0
    • +66
    /sources/gui/qml/components/ConfirmTreatmentTableEntry.qml
3:47 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review comments, misc. cleanup

Options
    • -2
    • +4
    /ConfirmTreatmentTableEntry.qml
    • -25
    • +0
    /ProgressLine.qml
    • -1
    • +0
    /denali.qrc
    • -4
    • +1
    /sources/gui/qml/components/ConfirmTreatmentSubTable.qml
    • -7
    • +47
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -2
    • +2
    /sources/view/VTreatmentBegin.h
3:09 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -0
    • +31
    /sources/model/dg/data/MDGAccelerometerData.h
    • -0
    • +32
    /sources/model/hd/data/MHDAccelerometerData.h
    • -8
    • +38
    /sources/model/hd/data/MHDVersionData.h
1:22 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -12
    • +11
    /sources/model/hd/data/MHDVersionData.h
    • -0
    • +7
    /sources/view/dg/data/VDGAccelerometerData.h
    • -0
    • +7
    /sources/view/hd/data/VHDAccelerometerData.h
12:17 pm

Peter Lucia <plucia@diality.com>

DEN-4598, DEN-4609, DEN-4607: Updated unit tests, removed unused Storage namespace from ApplicationController.cpp, removed saveNewTreatment function from ApplicationController.h

Options
    • -3
    • +3
    /denali.pro.user
    • -1
    • +0
    /sources/ApplicationController.cpp
    • -2
    • +0
    /sources/ApplicationController.h
    • -7
    • +8
    /sources/view/VTreatmentCreate.cpp
    • -31
    • +96
    /unittests/tst_views.cpp