application / sources

canbus

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Aug 2022
8:47 pm

Behrouz NematiPour

DEN-13645: IMP: Unhandled messages duplicate keys fix

- it has been observed that the unhandled messages are not logged correctly and turned out it is because of the Types of each parameter used as keys and keys can't be duplicate by default which caused issue for the unhandled messages, since they may have 6 parameter and all with F32 type which then becomes one parameter of type F32.

- an attribute has been defined for the config file with the format:

#--duplicate_key_on

#--duplicate_key_off

to allow or disallow the duplicate key at any point in the config file.

- Note that the save config parameters are always unique key like AlarmVolume which doesn't make sense to have duplicate entry.

Options
    • -1
    • +1
    ./MessageInterpreter.cpp
  2. … 9 more files in changeset.
Friday 12 Aug 2022
5:39 pm

Behrouz NematiPour

DEN-13645: IMP: General Implementation [-k, -K]

- The logic for the check-in and Ack messages reversed to be always disabled and can be enabled later if needed.

- For Integration/Unit tests the application needs to be called with these two switches otherwise tests will fail.

Options
    • -4
    • +4
    ./MessageDispatcher.cpp
    • -1
    • +1
    ./MessageInterpreter.cpp
  3. … 4 more files in changeset.
Wednesday 03 Aug 2022
11:10 pm

Behrouz NematiPour

DEN-13645: IMP: General Implementation

DEN-13447: UI able to send its final POST result to HD by request

Options
    • -0
    • +3
    ./MessageDispatcher.h
    • -0
    • +1
    ./MessageGlobals.h
    • -0
    • +1
    ./MessageInterpreter.cpp
  4. … 9 more files in changeset.
2:59 am

Behrouz NematiPour

DEN-13489 IMP: General Implementation

DEN-13035: Update alarm body messages

- Removed the exclamation mark icon form the Alarm Dialog.

- Removed the exclamation mark icon form the Alarm Bar.

- Made the whole AlarmDialog title bar doubleClick and diagnostics opener if the alarm is not minimizable.

- Moved the Alarm ID from title to the bottom left of the dialog with format: "ID:<id>".

- Clipped the AlarmDialon body message area, crop the text if longer than dialog area.

- Changed the "settings" property name of the VSettings to "instructions".

- Changed the date/time formats keys to simplify the code and conf file.

- Implemented the Alarm Body messages, to load from Alams/Alarms.conf, instead of the FW.

- The FW texts/documents will still being used if the Alarms.conf doesn't have a definition.

- A instruction base capability has also been added to the MVC, but UI still not supporting it.

Options
    • -3
    • +3
    ./MessageInterpreter.cpp
  2. … 18 more files in changeset.
Tuesday 26 Jul 2022
12:20 am

Behrouz NematiPour

DEN-13489: IMP: General Implementation for any bugs and any other implementations

- Enable Dialin logging CL switch has changed to disable dialin logging, to make the dialin logging as enabled by default and removed -d from run.sh. [Sean's Request]

- Added log unhandled as error to the unhandled reader as well.

- Implemented the NoCANBus to be used when no CANBus enabled. For now it is only bypassing the create treatment button command and helps to get to the treatment parameters for the touchscreen test. [EEMN's Support]

- Fixed a bug on the Volume Adjustment on post, sending to HD to update HD alarm volume with previous, adjusted value, which was sending a request one again receiving HD response, and it was a potential crash loop.

- Added disable acknowledgment logs (req,bak) CL switch, -K : --disable-acknow-log [Sean's Request]

Options
    • -5
    • +5
    ./FrameInterface.cpp
    • -9
    • +9
    ./MessageDispatcher.cpp
    • -1
    • +3
    ./MessageInterpreter.cpp
  4. … 12 more files in changeset.
Monday 25 Jul 2022
6:44 pm

Behrouz NematiPour

DEN-13489 IMP: General Implementation

DEN-12838: UI shall store the latest alarm volume and resend that to HD on POST

DEN-11539: Service password initial setup

Options
    • -2
    • +1
    ./MessageDispatcher.cpp
  2. … 12 more files in changeset.
Wednesday 01 Jun 2022
2:07 am

Behrouz NematiPour

DEN-12558: HD does not transition to service mode

- implemented the service mode confirmation

- decreased the dialog animation duration

- renamed the service dates MVC to differentiate with service mode.

Options
    • -2
    • +13
    ./MessageDispatcher.cpp
    • -1
    • +2
    ./MessageDispatcher.h
    • -3
    • +7
    ./MessageGlobals.h
    • -3
    • +5
    ./MessageInterpreter.cpp
  5. … 29 more files in changeset.
Monday 23 May 2022
6:04 pm

Behrouz NematiPour

wrapping up multiple sprint codes

- LOG: Added a CLI option to disable the Check-In logs by adding -k, --disable-check-in-log at the CLI. This was interrupting the log tests. The build macro has been removed.

- POST: During the coverage find out that the getter functions have not even been called in the ApplicationPost.

- CloudSync: Added the Treatment Code(TxCode), received from the cloud after the Treatment Report stored by Cloud System. It is a message communication between UI<=(2008)=CS.

- CloudSync: Two error added for the 2008: TxCode

- CloudSync: Due to some issues on Cloud System regarding the credential expiration, It has been asked to add a temporary workaround to send the credentials (1004) before message 1006:Device State, 1007:Treatment Report.

- DEN-12727: Treatment Parameter Screen: Added more space between the parameters components specially the Temperature slider and the option on top.

- DEN-12829: Enabled the back button on the Start Treatment Screen

- DEN-12761: Enabled an empty Patient ID.

It has not yet been implemented on the CloudSync App, so if sent empty CloudSystem will later reject to store the TxReport.

When later implemented an unassigned random Patient ID will be created for that TxReport to be later defined and assigned.

- DEN-12837, DEN-12840: The Disinfection Scheduling Entry and the Confirm button have been removed from the "Dialysate Generator Settings" screen.

- DEN-12837, DEN-12840: The "Dialysate Generator Settings" changed to "DG Cleaning" for the menu option and the screen title.

- Settings: The Clear Alarm Condition button has been removed from the settings screen for the release.

- Settings: The options which has no implementation for the phase 1 have been removed from the Settings screen Service mode options. [Language, Calibration, SW Update, Factory Reset]

- DEN-12841: Reworded the password entries in Service screen and for WiFi Join Screen.

- TxCode, TxReport: removed the commented out Treatment Report Parameters from the code.

- LOG: added one character space int he DEBUG log for the Not Enough Data in Types.

- Settings: The Service Dates default values changed from 0 to "" since they are strings.

- Settings: Added some clarification for the Home screen greetings

Options
    • -3
    • +3
    ./MessageInterpreter.cpp
  2. … 32 more files in changeset.
Monday 09 May 2022
9:27 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./CanInterface.cpp
    • -1
    • +1
    ./CanInterface.h
    • -1
    • +1
    ./FrameInterface.cpp
    • -1
    • +1
    ./FrameInterface.h
    • -1
    • +1
    ./MessageAcknowModel.cpp
    • -1
    • +1
    ./MessageAcknowModel.h
    • -1
    • +1
    ./MessageBuilder.cpp
    • -1
    • +1
    ./MessageDispatcher.cpp
    • -1
    • +1
    ./MessageDispatcher.h
    • -1
    • +1
    ./MessageGlobals.h
    • -1
    • +1
    ./MessageInterpreter.cpp
  12. … 149 more files in changeset.
Monday 18 Apr 2022
5:46 pm

Behrouz NematiPour

DEN-12597 Code Review

http://dvm-linux02:8060/cru/UI-DEN-12258-1#c12773

Disabled the coco end as well, which caused the coco to log a lot of warnings.

Options
    • -16
    • +16
    ./CanInterface.cpp
    • -8
    • +8
    ./FrameInterface.cpp
    • -2
    • +2
    ./MessageAcknowModel.cpp
    • -2
    • +2
    ./MessageBuilder.cpp
    • -9
    • +9
    ./MessageDispatcher.cpp
    • -2
    • +2
    ./MessageGlobals.h
    • -4
    • +4
    ./MessageInterpreter.cpp
  8. … 74 more files in changeset.
Monday 28 Mar 2022
12:39 pm

Behrouz NematiPour

DEN-12424: INT

- Adding the new 3 params of the alarm trigger

- Adding Rejection

- prepare for the singletons quit which are not in order, the quit should be done manually to be in order.

Options
    • -2
    • +0
    ./CanInterface.h
    • -2
    • +0
    ./FrameInterface.h
    • -2
    • +0
    ./MessageAcknowModel.h
    • -2
    • +0
    ./MessageDispatcher.h
    • -1
    • +1
    ./MessageGlobals.h
  6. … 16 more files in changeset.
Monday 21 Mar 2022
7:36 pm

Behrouz NematiPour

DEN-12426: LTS: Bug / CR / Develop Coco / Manual

- removed the "// coco begin validated" to disable the manually validated coverage.

Options
    • -16
    • +16
    ./CanInterface.cpp
    • -8
    • +8
    ./FrameInterface.cpp
    • -2
    • +2
    ./MessageAcknowModel.cpp
    • -2
    • +2
    ./MessageBuilder.cpp
    • -9
    • +9
    ./MessageDispatcher.cpp
    • -2
    • +2
    ./MessageGlobals.h
    • -4
    • +4
    ./MessageInterpreter.cpp
  8. … 75 more files in changeset.
10:20 am

Behrouz NematiPour

DEN-12438: The In-Treatment Dialysate Flow section value is not updated

During the change of the parent flow class to the Dialysate flow and Blood flow, one thing which has not been caught during the development and code review is that the length of the Dialysate flow has changed as well from 8 to 7.

It has been caught by LTTS during their regression testing.

Options
    • -1
    • +1
    ./MessageGlobals.h
  2. … 1 more file in changeset.
Thursday 10 Mar 2022
7:41 pm

Behrouz NematiPour

DEN-12262: INT: Support and debugging

- Fixing the DG Valves/Temperature messages

- Fixing the CloudSync RegisterDeviceRequest

- Fixed/Cherry-Picked the Dialin-log conditions.

- Cleaned up the debug messages.

Options
    • -1
    • +0
    ./CanInterface.cpp
    • -7
    • +7
    ./FrameInterface.cpp
    • -1
    • +1
    ./MessageGlobals.h
  4. … 18 more files in changeset.
12:59 pm

Behrouz NematiPour

DEN-12262: INT: Log Dialin Messages

- Log Dialin messages as part of the unhandled messages.

Options
    • -0
    • +1
    ./MessageGlobals.h
    • -21
    • +46
    ./MessageInterpreter.cpp
  3. … 10 more files in changeset.
Wednesday 09 Mar 2022
4:53 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./FrameInterface.cpp
    • -1
    • +1
    ./MessageGlobals.h
    • -1
    • +1
    ./MessageInterpreter.cpp
  4. … 75 more files in changeset.
4:47 pm

Behrouz NematiPour

Merge branch 'DEN-12121-sw_dev-sprint-65' into staging

Options
    • -3
    • +5
    ./MessageGlobals.h
    • -0
    • +4
    ./MessageInterpreter.cpp
  3. … 5 more files in changeset.
Tuesday 08 Mar 2022
6:30 pm

Behrouz NematiPour

Merge branch 'DEN-12258-UI-BN-S66' into develop

- merge conflict resolution.

Options
    • -2
    • +2
    ./FrameInterface.cpp
    • -0
    • +1
    ./MessageGlobals.h
    • -21
    • +46
    ./MessageInterpreter.cpp
  4. … 2 more files in changeset.
5:55 pm

Behrouz NematiPour

DEN-12262: INT: Log Dialin Messages

- Log Dialin messages as part of the unhandled messages.

Options
    • -2
    • +2
    ./FrameInterface.cpp
    • -0
    • +1
    ./MessageGlobals.h
    • -21
    • +46
    ./MessageInterpreter.cpp
  4. … 10 more files in changeset.
Friday 04 Mar 2022
12:16 am

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
    • -1
    • +2
    ./MessageInterpreter.cpp
12:15 am

Behrouz NematiPour

UI-DEN-12182: UI-DEN-12182-2

- During code review of my code, cleaned up the code.

Options
    • -1
    • +2
    ./MessageInterpreter.cpp
  2. … 6 more files in changeset.
Wednesday 02 Mar 2022
5:41 pm

Michael Garthwaite

Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

Options
    • -3
    • +2
    ./MessageGlobals.h
  2. … 2 more files in changeset.
5:41 pm

Michael Garthwaite

DEN-12121: Updates per code review

Options
    • -3
    • +2
    ./MessageGlobals.h
  2. … 8 more files in changeset.
Tuesday 01 Mar 2022
2:23 pm

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
    • -1
    • +1
    ./MessageGlobals.h
2:22 pm

Behrouz NematiPour

DEN-12204 Code Analysis

- Broke the build and fixed.

Options
    • -1
    • +1
    ./MessageGlobals.h
10:01 am

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
    • -1
    • +1
    ./MessageGlobals.h
10:01 am

Behrouz NematiPour

DEN-12204 Code Analysis

- cppcheck is confusing Message struct in different scopes and giving an error in CloudSync file about the struct in MessageGlobals, but the error has been fixed to avoid build fail.

Options
    • -1
    • +1
    ./MessageGlobals.h
  2. … 2 more files in changeset.
Thursday 24 Feb 2022
6:24 pm

Michael Garthwaite

Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

Options
    • -1
    • +4
    ./MessageGlobals.h
    • -0
    • +4
    ./MessageInterpreter.cpp
  3. … 5 more files in changeset.
6:22 pm

Michael Garthwaite

DEN-12121: Further linkage for updating values on screen relating to DEN-12118

Options
    • -1
    • +4
    ./MessageGlobals.h
  2. … 2 more files in changeset.
Wednesday 23 Feb 2022
6:25 pm

Michael Garthwaite

Merge branch 'staging' into DEN-12121-sw_dev-sprint-65

Options
    • -8
    • +8
    ./MessageInterpreter.cpp
  2. … 9 more files in changeset.