application

sources

Clone Tools

Stats

Commits this week: 2
Total Committers: 14
Last Commit: 10 Feb
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 24 Jan 2021
9:13 pm

Behrouz NematiPour

DEN-6612 UI_DVT: Pre-Treatment Ultrafiltration

- This story wasn't part of the current sprint S37 but while I worked on it to be able to push it to master ASAP, so put the story as the commit comment.

Options
    • -2
    • +2
    ./canbus/MessageDispatcher.cpp
    • -0
    • +2
    ./view/VTreatmentBegin.h
    • -2
    • +2
    ./view/hd/alarm/VAlarmStatus.cpp
  4. … 5 more files in changeset.
1:59 pm

Behrouz NematiPour

Why the doGetDevices is a public slots, therefore, is publicly accessible while you have a property defined for that? That's one of the reasons why I insisted to use macros to avoid this kind of in...

Why the doGetDevices is a public slots, therefore, is publicly accessible while you have a property defined for that?
That's one of the reasons why I insisted to use macros to avoid this kind of inconsistencies.
Also, the name of the property/signal/slot does not match.
if the property type is vTYPE and its name is vVARIABLE and the vSIGNAL is "Changed" then by PROPERTY macro definition it has to be like below with slot defined as private.

Q_PROPERTY(     vTYPE   vVARIABLE                                   \
                 READ   vVARIABLE                                   \
                 WRITE  vVARIABLE                                   \
                 NOTIFY vVARIABLE##vSIGNAL)                         \


The do/did/on prefixes will be used for none property matters.

12:44 pm

Behrouz NematiPour

what is this? why created and why ignored?

what is this?
why created and why ignored?

12:29 pm

Behrouz NematiPour

This is not a prefered approach and there are better ways of doing it. As Qt mentions in the document: QAbstractItemModel Subclass A model can be defined by subclassing QAbstractItemModel. This i...

This is not a prefered approach and there are better ways of doing it.
As Qt mentions in the document:


QAbstractItemModel Subclass
A model can be defined by subclassing QAbstractItemModel. This is the best approach if you have a more complex model that cannot be supported by the other approaches. A QAbstractItemModel can also automatically notify a QML view when the model data changes.

12:22 pm

Behrouz NematiPour

it has been done before please don't do this again RESOLVED

it has been done before please don't do this again
RESOLVED

12:19 pm

Behrouz NematiPour

RESOLVED

RESOLVED

Thursday 21 Jan 2021
7:13 pm

Behrouz NematiPour

DEN-5757: Code Coverage

Options
    • -0
    • +2
    ./gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -0
    • +2
    ./gui/qml/pages/pretreatment/create/PreTreatmentUltrafiltration.qml
7:10 pm

Behrouz NematiPour

Merge branch 'master' into DEN-5751_Pre-TreatmentUltrafiltration

Options
    • -3
    • +17
    ./canbus/MessageDispatcher.cpp
    • -0
    • +2
    ./canbus/MessageDispatcher.h
    • -2
    • +4
    ./canbus/MessageGlobals.h
    • -42
    • +47
    ./canbus/MessageInterpreter.cpp
    • -20
    • +26
    ./gui/GuiGlobals.h
    • -12
    • +55
    ./gui/qml/globals/Colors.qml
    • -8
    • +9
    ./gui/qml/globals/Variables.qml
    • -108
    • +110
    ./gui/qml/main.qml
    • -20
    • +50
    ./model/MModel.h
    • -14
    • +44
    ./model/hd/adjustment/MTreatmentAdjustRequests.h
  11. … 3 more files in changeset.
5:21 pm

Behrouz NematiPour

Server coverage issue fixed

- This line was not covered on server although it was covered on local.

Tested locally and it is working.

Options
    • -1
    • +3
    ./view/hd/alarm/VAlarmStatus.cpp
1:11 pm

Behrouz NematiPour

Build failed on server because the fw common branch master was changed.

- commented out the removed enum from application.

Options
    • -2
    • +2
    ./model/hd/alarm/MAlarmStatusData.cpp
    • -4
    • +4
    ./view/hd/data/VHDTreatmentStatesData.cpp
12:55 pm

Peter Lucia <plucia@diality.com>

Merge master into DEN-4860_BLE

Options
    • -0
    • +2
    ./canbus/MessageDispatcher.cpp
    • -34
    • +36
    ./canbus/MessageInterpreter.cpp
    • -9
    • +5
    ./gui/GuiController.cpp
    • -1
    • +1
    ./gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    ./gui/qml/main.qml
    • -5
    • +16
    ./model/MModel.h
    • -2
    • +3
    ./model/hd/adjustment/MTreatmentAdjustRequests.h
    • -2
    • +6
    ./view/hd/alarm/VAlarmStatus.cpp
  9. … 5 more files in changeset.
Wednesday 20 Jan 2021
11:57 am

plucia  (deleted user)

Done

Done

11:56 am

Peter Lucia <plucia@diality.com>

DEN-4867: Code Review 0 - Requested Modifications

- Removed startBLETimer and killBLETimer so we are not creating and deleting timers. Only one timer will be used

- Added toggleBLETimer

- Logging measurements when they are received instead of using qDebug

- Passing device addr and name to BLEScanner instead of just addr so only a QBluetoothDeviceInfo object is necessary, allowing removal of the macAddress QString

- Removed VBluetoothDeviceInfo static cast in VBluetooth::doSelectDevice

Options
    • -75
    • +57
    ./bluetooth/BLEScanner.cpp
    • -6
    • +2
    ./bluetooth/BLEScanner.h
    • -2
    • +2
    ./gui/qml/pages/SettingsBluetooth.qml
    • -11
    • +13
    ./view/VBluetooth.cpp
    • -2
    • +2
    ./view/VBluetooth.h
  6. … 1 more file in changeset.
Tuesday 19 Jan 2021
8:55 pm

Behrouz NematiPour

2:40 pm

plucia  (deleted user)

2:39 pm

plucia  (deleted user)

RESOLVED

RESOLVED

11:38 am

Behrouz NematiPour

DEN-5753: Update Design Documents

- Fixed comments in some files of the Pre-Treatment Create.

Options
    • -2
    • +2
    ./gui/qml/pages/pretreatment/create/PreTreatmentConfirm.qml
    • -2
    • +2
    ./gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -2
    • +2
    ./gui/qml/pages/pretreatment/create/PreTreatmentPrime.qml
    • -2
    • +2
    ./gui/qml/pages/pretreatment/create/PreTreatmentUltrafiltration.qml
  5. … 1 more file in changeset.
11:33 am

Behrouz NematiPour

I will work on that later in prTx-UF story and it has only been fixed here since it wasn't passing the test sometimes while testing the Alarm design.

I will work on that later in prTx-UF story and it has only been fixed here since it wasn't passing the test sometimes while testing the Alarm design.

8:42 am

plucia  (deleted user)

Yes I know. I accidently clicked it and there's no way to unclick

Yes I know. I accidently clicked it and there's no way to unclick

8:39 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

8:39 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

8:36 am

pmontazemi  (deleted user)

Our process calls for only 1 UNRESOLVED and 1 RESOLVED response (comment) per thread please.

Our process calls for only 1 UNRESOLVED and 1 RESOLVED response (comment) per thread please.

Monday 18 Jan 2021
7:03 pm

Behrouz NematiPour

Much better, that should work. it's always a good practice to set the pointer to nullptr after delete, but since it is a local pointer that is fine. RESOLVED

Much better, that should work.
it's always a good practice to set the pointer to nullptr after delete, but since it is a local pointer that is fine.

RESOLVED

6:33 pm

plucia  (deleted user)

Fixed

Fixed

6:32 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -1
    • +4
    ./view/VBluetooth.cpp
5:32 pm

Behrouz NematiPour

1 - I mean that timer is not only for handling our implementation it may have another purpose which we are stopping by killing the only timer it has. 2 - in your timerEvent { ... if( ! _tim...

1 - I mean that timer is not only for handling our implementation it may have another purpose which we are stopping by killing the only timer it has.
2 - in your 

timerEvent {
    ...
    if( ! _timerIsActive ) return;
    ...
}
5:19 pm

Behrouz NematiPour

This is a leak/bug. Leak: A pointer to an object has been removed from the list and the object still exists and utilizing the memory (bug: and may even still doing some tasks).

This is a leak/bug.
Leak: A pointer to an object has been removed from the list and the object still exists and utilizing the memory (bug: and may even still doing some tasks).

5:16 pm

plucia  (deleted user)

Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped. That's the inte...


Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped.


That's the intention - to stop the timer. Since the UI is continually trying to reconnect to the last paired device while it is off, if a user goes into the bluetooth settings page and hits "Scan for devices", the timer is stopped during the scan to avoid conflicts between the timer and the scan.


I prefer to have a boolean flag to return from the virtual method in case we don't need it to handle the functionality we put there.


This doesn't make sense to me, can you clarify?

5:12 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:52 pm

Behrouz NematiPour

RESOLVED

RESOLVED