dd-firmware

Clone Tools

Stats

Commits this week: 43
Total Committers: 16
Last Commit: 17:15
Commits this week: 43

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Feb
11:24 am

Dara Navaei

LDT-3552 updated the array of the DD valves structure

Options
    • -6
    • +1
    /firmware/App/Controllers/Valves.h
11:23 am

Vendor - TEL - Sameer Poyil

remove #if 1 and add a TODO with this comment

remove #if 1 and add a TODO with this comment

11:22 am

Vendor - TEL - Sameer Poyil

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

10:11 am

Sean Nash

I suspect this is temporary. If so, just add a TODO comment to restore later.

I suspect this is temporary. If so, just add a TODO comment to restore later.

Wednesday 18 Feb
3:52 pm

Sean Nash

Only 1 return per function.

Only 1 return per function.

3:50 pm

Sean Nash

If result is U08, why are we returning U16?

If result is U08, why are we returning U16?

3:49 pm

Sean Nash

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

3:49 pm

Sean Nash

Only 1 return statement per function.

Only 1 return statement per function.

3:43 pm

Sean Nash

Fix alignment of all of the | separators.

Fix alignment of all of the | separators.

3:43 pm

Sean Nash

This table should be sorted, so this row needs to be moved up now.

This table should be sorted, so this row needs to be moved up now.

3:42 pm

Sean Nash

Fix alignment.

Fix alignment.

3:41 pm

Sean Nash

Why remove these functions. All static functions should be prototyped up here.

Why remove these functions. All static functions should be prototyped up here.

3:40 pm

Sean Nash

S in status should be capitalized.

S in status should be capitalized.

3:36 pm

Sean Nash

Any reason why pwmInCount can't just be a U32?

Any reason why pwmInCount can't just be a U32?

3:28 pm

Sean Nash

Do we really need a start state? Can't we just start in off state.

Do we really need a start state? Can't we just start in off state.

3:27 pm

Sean Nash

Add detail for alarm.

Add detail for alarm.

3:27 pm

Sean Nash

Remove extra spaces before =.

Remove extra spaces before =.

3:26 pm

Sean Nash

Don't need #define for zero.

Don't need #define for zero.

3:25 pm

Sean Nash

Looks like publish function moved to monitor (priority task). I actually don't think publish function should have moved, but if we move it we need to change interval timing here.

Looks like publish function moved to monitor (priority task). I actually don't think publish function should have moved, but if we move it we need to change interval timing here.

3:24 pm

Sean Nash

I would consider leaving publish here. Monitor is called from priority task. CAN publishing happens in general task.

I would consider leaving publish here. Monitor is called from priority task. CAN publishing happens in general task.

3:23 pm

Sean Nash

Remove blank line.

Remove blank line.

3:22 pm

Sean Nash

We should be a little more descriptive in brief here. Describe calculation of pump speed, monitoring for pump speed alarms and publishing pump data.

We should be a little more descriptive in brief here. Describe calculation of pump speed, monitoring for pump speed alarms and publishing pump data.

3:21 pm

Sean Nash

I think we can say none for Outputs.

I think we can say none for Outputs.

3:20 pm

Sean Nash

I don't see an alarm triggered in this function.

I don't see an alarm triggered in this function.

3:20 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

3:18 pm

Sean Nash

We don't need #defines for zero unless zero has some kind of meaning beyond zero.

We don't need #defines for zero unless zero has some kind of meaning beyond zero.

3:13 pm

Sean Nash

If leak sensor is coming via FPGA, it doesn't belong in GPIO unit. This unit is for GPIO pins on our microprocessor. GPIO pins on FPGA should be gotten using get functions in the FpgaDD unit.

If leak sensor is coming via FPGA, it doesn't belong in GPIO unit. This unit is for GPIO pins on our microprocessor. GPIO pins on FPGA should be gotten using get functions in the FpgaDD unit.

12:11 pm

Vinayakam Mani

Mask value seems wrong. please update per HDD.

Mask value seems wrong. please update per HDD.

10:53 am

Vendor - TEL - Jashwant Gantyada

this has already been addressed. I think you have commented on removed code.

this has already been addressed. I think you have commented on removed code.

10:34 am

Vendor - TEL - Jashwant Gantyada

added a todo for testing it after we have the new beta 2 units.

added a todo for testing it after we have the new beta 2 units.